Issue 1409813006: Remove QuicPacketCreator::fec_group_number_; replace it with QuicFecGroupInterface::FecGroupNumber(…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409813006: Remove QuicPacketCreator::fec_group_number_; replace it with QuicFecGroupInterface::FecGroupNumber(… (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton

Modified:
5 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@106425553

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove QuicPacketCreator::fec_group_number_; replace it with QuicFecGroupInterface::FecGroupNumber(). No behavior change expected. Merge internal change: 106432163 R=rtennet@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -13 lines)			Patch
M	net/quic/quic_fec_group.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_fec_group.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_fec_group_interface.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	6 chunks	+13 lines, -8 lines	0 comments	Download

Depends on Patchset:

Issue 1408963003 Patch 1

Dependent Patchsets:

Issue 1424653008 Patch 1

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages