Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409813002: Fix another place where identifiers were not being re-resolved correctly (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix another place where identifiers were not being re-resolved correctly R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d2b1edb695e35455ca0f5735385c66e4c3e397db

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -225 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 13 chunks +205 lines, -202 lines 2 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 2 months ago (2015-10-15 20:21:07 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1409813002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1409813002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode203 pkg/analyzer/lib/src/task/dart.dart:203: * Only non-empty in strongMode Add dot?
5 years, 2 months ago (2015-10-15 20:57:39 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1409813002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1409813002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode203 pkg/analyzer/lib/src/task/dart.dart:203: * Only non-empty in strongMode Done
5 years, 2 months ago (2015-10-15 20:59:22 UTC) #4
Brian Wilkerson
5 years, 2 months ago (2015-10-15 20:59:52 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d2b1edb695e35455ca0f5735385c66e4c3e397db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698