Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1409803003: dart2js cps: More interceptor optimizations and fixes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Remove unused getter again Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index 1b4d2f4a755681ec62b1455c564c23dfefbe19ff..b09f1d299f6f4be03c695f3c0f39e8c8c046e80d 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -81,17 +81,15 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
});
});
tag("HIR", () {
+ String formatParameter(cps_ir.Parameter param) {
+ return '${names.name(param)} ${param.type}';
+ }
if (entryPointParameters != null) {
- String formatParameter(cps_ir.Parameter param) {
- return '${names.name(param)} ${param.type}';
- }
String params = entryPointParameters.map(formatParameter).join(', ');
printStmt('x0', 'Entry ($params)');
}
- for (cps_ir.Parameter param in block.parameters) {
- String name = names.name(param);
- printStmt(name, "Parameter $name [useCount=${countUses(param)}]");
- }
+ String params = block.parameters.map(formatParameter).join(', ');
+ printStmt('x0', 'Parameters ($params)');
visit(block.body);
});
});
@@ -327,7 +325,8 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
}
visitInterceptor(cps_ir.Interceptor node) {
- return "Interceptor(${formatReference(node.input)})";
+ return "Interceptor(${formatReference(node.input)}, "
+ "${node.interceptedClasses})";
sra1 2015/10/28 02:31:52 use single quotes unless string contains single qu
asgerf 2015/10/28 10:06:31 Done.
}
visitCreateFunction(cps_ir.CreateFunction node) {

Powered by Google App Engine
This is Rietveld 408576698