cc: Add a test that the IOSurface drawing path makes the right context calls.

cc/layers/io_surface_layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/io_surface_layer_impl.h"
 
 #include "base/stringprintf.h"
 #include "cc/layers/quad_sink.h"
 #include "cc/output/gl_renderer.h"  // For the GLC() macro.
 #include "cc/output/output_surface.h"
@@ skipping 63 matching lines @@
 
     // FIXME: Do this in a way that we can track memory usage.
     if (!io_surface_texture_id_) {
       io_surface_texture_id_ = context3d->createTexture();
       io_surface_resource_id_ =
           resource_provider->CreateResourceFromExternalTexture(
               GL_TEXTURE_RECTANGLE_ARB,
               io_surface_texture_id_);
     }
 
-    GLC(context3d, context3d->activeTexture(GL_TEXTURE0));

[jamesr, 2013/04/19 00:05:09]

what was the actual bug? this call?

[danakj, 2013/04/19 00:06:41]

mac context virtualization is the bug on TOT.

the bug I caused was doing bindTexture etc in resource provider with
GL_TEXTURE_2D target. Bo fixed that last night.

[danakj, 2013/04/19 00:07:05]

I think this call is just redundant cuz we're always in this state when we leave
the renderer - please correct me if I'm wrong.

     GLC(context3d,
         context3d->bindTexture(GL_TEXTURE_RECTANGLE_ARB,
                                io_surface_texture_id_));
-    GLC(context3d,
-        context3d->texParameteri(
-            GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_MIN_FILTER, GL_LINEAR));
-    GLC(context3d,
-        context3d->texParameteri(
-            GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_MAG_FILTER, GL_LINEAR));
-    GLC(context3d,
-        context3d->texParameteri(
-            GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE));
-    GLC(context3d,
-        context3d->texParameteri(
-            GL_TEXTURE_RECTANGLE_ARB, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE));
     context3d->texImageIOSurface2DCHROMIUM(GL_TEXTURE_RECTANGLE_ARB,
                                            io_surface_size_.width(),
                                            io_surface_size_.height(),
                                            io_surface_id_,
                                            0);
     // Do not check for error conditions. texImageIOSurface2DCHROMIUM() is
     // supposed to hold on to the last good IOSurface if the new one is already
     // closed. This is only a possibility during live resizing of plugins.
     // However, it seems that this is not sufficient to completely guard against
     // garbage being drawn. If this is found to be a significant issue, it may
@@ skipping 45 matching lines @@
 
   io_surface_id_ = io_surface_id;
   io_surface_size_ = size;
 }
 
 const char* IOSurfaceLayerImpl::LayerTypeAsString() const {
   return "IOSurfaceLayer";
 }
 
 }  // namespace cc