Aura on Android: Stub implementation of SelectFileDialog.

ui/shell_dialogs/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
@@ skipping 34 matching lines @@
   ]
 
   if (use_aura) {
     if (is_mac) {
       # Will be automatically filtered out on non-Mac.
       sources -= [ "select_file_dialog_mac.mm" ]
     }
     deps += [ "//ui/aura" ]
   }
 
-  if (is_android) {
+  if (is_android && !use_aura) {

[brettw, 2015/10/21 02:51:03]

What I would do for this:

if (is_android) {
  if (use_aura) {
    sources += [ <stuff you have below> ]
  } else {
    sources += [
      <the android files you remove below, so there are no sources -= calls>
    ]
    <rest of the stuff here>
  }
}

Obviously remove the duplicated files from the sources list above.

[mfomitchev, 2015/10/21 22:44:04]

Done - I think. There's nothing in <rest of the stuff here>, so I've just left
two separate ifs. I think it's also nicer to avoid an extra nesting level.

     deps += [
       "//ui/android",
       "//ui/android:ui_java",
       "//ui/base:ui_base_jni_headers",
     ]
     include_dirs = [ "$root_gen_dir/ui" ]
     libs = [ "jnigraphics" ]
   }
 
+  if (is_android && use_aura) {
+    sources += [
+      "select_file_dialog_auraandroid.cc",
+      "select_file_dialog_auraandroid.h",
+    ]
+    sources -= [
+      "android/shell_dialogs_jni_registrar.cc",
+      "android/shell_dialogs_jni_registrar.h",
+      "select_file_dialog_android.cc",
+      "select_file_dialog_android.h",
+    ]
+  }
+
   if (is_win) {
     deps += [ "//win8:metro_viewer" ]
   }
 }
 
 test("shell_dialogs_unittests") {
   sources = [
     "select_file_dialog_win_unittest.cc",
   ]
 
   deps = [
     ":shell_dialogs",
     "//base",
     "//base/test:test_support",
     "//base/test:run_all_unittests",
     "//testing/gtest",
   ]
 }