Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1409763004: [types] Use the TypeCache consistently for common types. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[types] Use the TypeCache consistently for common types. Rename ZoneTypeCache to TypeCache and use a single shared (immutable) instance consistently to cache the most commonly used types. Also serves as a chokepoint for defining those types, so we don't repeat the definition (and possible bugs) in various places. R=jarin@chromium.org Committed: https://crrev.com/23ac686ff8b057a2941b4c34afda52dab280e85e Cr-Commit-Position: refs/heads/master@{#31631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -190 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/access-builder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 6 chunks +19 lines, -21 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 6 chunks +14 lines, -22 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M src/compiler/typer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +2 lines, -10 lines 0 comments Download
A + src/type-cache.h View 4 chunks +30 lines, -6 lines 0 comments Download
A src/type-cache.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/typing-asm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/typing-asm.cc View 2 chunks +2 lines, -8 lines 0 comments Download
D src/zone-type-cache.h View 1 chunk +0 lines, -81 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-28 12:18:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409763004/1
5 years, 1 month ago (2015-10-28 12:30:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 13:17:23 UTC) #5
Jarin
lgtm
5 years, 1 month ago (2015-10-28 13:18:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409763004/1
5 years, 1 month ago (2015-10-28 13:29:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 13:31:13 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 13:31:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ac686ff8b057a2941b4c34afda52dab280e85e
Cr-Commit-Position: refs/heads/master@{#31631}

Powered by Google App Engine
This is Rietveld 408576698