base/memory/discardable_shared_memory_unittest.cc - Issue 1409743002: Re-land: base: Use MADV_REMOVE instead of ftruncate to purge discardable memory segments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/discardable_shared_memory_unittest.cc

Issue 1409743002: Re-land: base: Use MADV_REMOVE instead of ftruncate to purge discardable memory segments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/memory/discardable_shared_memory.cc ('K') | « base/memory/discardable_shared_memory.cc ('k') | content/common/host_discardable_shared_memory_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/memory/discardable_shared_memory_unittest.cc

diff --git a/base/memory/discardable_shared_memory_unittest.cc b/base/memory/discardable_shared_memory_unittest.cc

index d5b71d31cb0b9649087bea036d3ecf6e8cc40a21..7075139a6ef78331430a420ec12cf8b25aed0cdd 100644

--- a/base/memory/discardable_shared_memory_unittest.cc

+++ b/base/memory/discardable_shared_memory_unittest.cc

@@ -343,21 +343,5 @@ TEST(DiscardableSharedMemoryTest, Close) {

memory.Unlock(0, 0);

}

-#if defined(DISCARDABLE_SHARED_MEMORY_SHRINKING)

-TEST(DiscardableSharedMemoryTest, Shrink) {

- const uint32 kDataSize = 1024;

- TestDiscardableSharedMemory memory;

- bool rv = memory.CreateAndMap(kDataSize);

- ASSERT_TRUE(rv);

- EXPECT_NE(0u, memory.mapped_size());

- // Mapped size should be 0 after shrinking memory segment.

- memory.Shrink();

- EXPECT_EQ(0u, memory.mapped_size());

-#endif

} // namespace

} // namespace base