Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 1409733009: ARM: Fix double use of IP when storing object fields with large offsets. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
diff --git a/runtime/vm/assembler_arm.cc b/runtime/vm/assembler_arm.cc
index 31824b1a8484a323c3a1130b7da93fba372e11c3..2b59966978a8094e93ec5a930ba3796b87f4d89a 100644
--- a/runtime/vm/assembler_arm.cc
+++ b/runtime/vm/assembler_arm.cc
@@ -1908,8 +1908,11 @@ void Assembler::StoreIntoObjectNoBarrierOffset(Register object,
StoreIntoObjectNoBarrier(object, FieldAddress(object, offset), value,
old_content);
} else {
- AddImmediate(IP, object, offset - kHeapObjectTag);
- StoreIntoObjectNoBarrier(object, Address(IP), value, old_content);
+ ASSERT(object != R9);
Florian Schneider 2015/11/04 20:58:01 Not sure if this is always guaranteed: I think you
+ Push(R9);
+ AddImmediate(R9, object, offset - kHeapObjectTag);
+ StoreIntoObjectNoBarrier(object, Address(R9), value, old_content);
+ Pop(R9);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698