Issue 140973005: Chrome allows WebTouchPoint to store WebFloatPoint, instead of WebPoint.

Issue 140973005: Chrome allows WebTouchPoint to store WebFloatPoint, instead of WebPoint. (Closed)

Created:
6 years, 11 months ago by tdresser

Modified:
6 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jdduke (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Chrome allows WebTouchPoint to store WebFloatPoint, instead of WebPoint. This is the first of three patches converting WebTouchPoint to use WebFloatPoint instead of WebPoint. This introduces some temporary casts to WebPoint in chromium, which will be removed as soon as blink has WebTouchPoint storing it's location in a WebFloatPoint. The second patch (https://codereview.chromium.org/149053002/) will be a blink modification to store WebFloatPoint, and the third patch (https://codereview.chromium.org/148453012/) will clean up the chromium side. BUG=336807 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247739

Patch Set 1 #

Patch Set 2 : Fix semicolon. #

Total comments: 2

Patch Set 3 : Use static_cast. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
M	content/renderer/input/input_handler_proxy.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/shell/renderer/test_runner/EventSender.cpp	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestPlugin.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tdresser

3 sided patch: this is the first side, which just forces some type conversions. jam@, ...

6 years, 10 months ago (2014-01-28 22:04:58 UTC) #1

jam

lgtm https://codereview.chromium.org/140973005/diff/20001/content/shell/renderer/test_runner/TestPlugin.cpp File content/shell/renderer/test_runner/TestPlugin.cpp (right): https://codereview.chromium.org/140973005/diff/20001/content/shell/renderer/test_runner/TestPlugin.cpp#newcode88 content/shell/renderer/test_runner/TestPlugin.cpp:88: snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", (int)points[i].position.x, (int)points[i].position.y, ...

6 years, 10 months ago (2014-01-29 00:54:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/140973005/40001

6 years, 10 months ago (2014-01-29 13:23:52 UTC) #3

tdresser

https://codereview.chromium.org/140973005/diff/20001/content/shell/renderer/test_runner/TestPlugin.cpp File content/shell/renderer/test_runner/TestPlugin.cpp (right): https://codereview.chromium.org/140973005/diff/20001/content/shell/renderer/test_runner/TestPlugin.cpp#newcode88 content/shell/renderer/test_runner/TestPlugin.cpp:88: snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", (int)points[i].position.x, (int)points[i].position.y, pointState(points[i].state)); ...

6 years, 10 months ago (2014-01-29 15:02:42 UTC) #4

Message was sent while issue was closed.

Change committed as 247739

Expand Messages | Collapse Messages