Remove AudioBufferSourceNode.looping

Remove AudioBufferSourceNode.looping

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/v1KTqntSFKU/UWoupLnxPawJ

BUG=335126
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165267

[philipj_slow, 2014-01-16 16:26:46]

I'm going to bed soon, so here's a pre-emptive review on the assumption that the
blink-dev thread will get its 3 LGTMs and no objections.

[philipj_slow, 2014-01-16 16:38:10]

https://codereview.chromium.org/140973002/diff/1/Source/core/frame/UseCounter.h
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/140973002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.h:135: UnusedSlot10, // Removed, was
WebAudioLooping.
Should I renumber the rest of the unused slots instead? One way is annoying for
the author and the other is annoying for the reader :/

[eseidel, 2014-01-16 16:56:37]

lgtm

https://codereview.chromium.org/140973002/diff/40001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/140973002/diff/40001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:135: UnusedSlot10, // Removed, was
AudioBufferSourceNode.looping.
We should come up with a better system here.  Maybe XXXAudioBufferSourceNode? 
Or REMOVEDAudioBufferSourceNode?

[philipj_slow, 2014-01-16 17:15:58]

https://codereview.chromium.org/140973002/diff/40001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/140973002/diff/40001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:135: UnusedSlot10, // Removed, was
AudioBufferSourceNode.looping.
On 2014/01/16 16:56:38, eseidel wrote:
> We should come up with a better system here.  Maybe XXXAudioBufferSourceNode? 
> Or REMOVEDAudioBufferSourceNode?

REMOVEDOldCruft has a nice ring to it. I'll push this CL through and then
(tomorrow) submit another one to convert UnusedSlotXX to that, for your
reviewing pleasure.

[commit-bot: I haz the power, 2014-01-16 17:16:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/140973002/40001

[commit-bot: I haz the power, 2014-01-16 18:58:59]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Raymond Toy (Google), 2014-01-16 19:26:04]

On 2014/01/16 18:58:59, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_blink_rel for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

I think you can delete deprecated-audiobuffersource-looping.html from the layout
tests.  It looks exactly like audiobuffersource-loop-comprehensive.html except
looping is used instead of loop.

[philipj_slow, 2014-01-17 00:16:21]

On 2014/01/16 19:26:04, rtoy wrote:
> On 2014/01/16 18:58:59, I haz the power (commit-bot) wrote:
> > Retried try job too often on linux_blink_rel for step(s) webkit_tests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> 
> I think you can delete deprecated-audiobuffersource-looping.html from the
layout
> tests.  It looks exactly like audiobuffersource-loop-comprehensive.html except
> looping is used instead of loop.

Thanks, I've removed the test!

[commit-bot: I haz the power, 2014-01-17 00:17:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/140973002/60007

[commit-bot: I haz the power, 2014-01-17 01:41:04]

Change committed as 165267