Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409713002: cc: Remove cc::ContentLayerClient::PaintContents(SkCanvas*, ...). (Closed)

Created:
5 years, 2 months ago by jbroman
Modified:
5 years, 2 months ago
Reviewers:
danakj, pdr.
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove cc::ContentLayerClient::PaintContents(SkCanvas*, ...). It has no remaining call sites. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c389c80986ff755aad066c9691d6613fd9ae111c Cr-Commit-Position: refs/heads/master@{#354378}

Patch Set 1 #

Total comments: 2

Patch Set 2 : restore comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -153 lines) Patch
M cc/blink/web_content_layer_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M cc/blink/web_content_layer_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M cc/layers/content_layer_client.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/layers/picture_image_layer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/picture_image_layer.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M cc/test/solid_color_content_layer_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/solid_color_content_layer_client.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 4 chunks +4 lines, -30 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbroman
It looks like this can go away, and once it does, so can the similar ...
5 years, 2 months ago (2015-10-15 19:22:26 UTC) #2
danakj
LGTM % pdr https://codereview.chromium.org/1409713002/diff/1/cc/blink/web_content_layer_impl.h File cc/blink/web_content_layer_impl.h (left): https://codereview.chromium.org/1409713002/diff/1/cc/blink/web_content_layer_impl.h#oldcode37 cc/blink/web_content_layer_impl.h:37: // ContentLayerClient implementation. Keep the comment, ...
5 years, 2 months ago (2015-10-15 19:52:53 UTC) #3
jbroman
https://codereview.chromium.org/1409713002/diff/1/cc/blink/web_content_layer_impl.h File cc/blink/web_content_layer_impl.h (left): https://codereview.chromium.org/1409713002/diff/1/cc/blink/web_content_layer_impl.h#oldcode37 cc/blink/web_content_layer_impl.h:37: // ContentLayerClient implementation. On 2015/10/15 at 19:52:52, danakj wrote: ...
5 years, 2 months ago (2015-10-15 20:19:00 UTC) #4
pdr.
Thanks! I had this on my todo list. LGTM
5 years, 2 months ago (2015-10-15 22:00:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409713002/20001
5 years, 2 months ago (2015-10-15 22:01:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 22:09:48 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 22:11:16 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c389c80986ff755aad066c9691d6613fd9ae111c
Cr-Commit-Position: refs/heads/master@{#354378}

Powered by Google App Engine
This is Rietveld 408576698