Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: snapshot/win/end_to_end_test.py

Issue 1409693011: win: Only retry in UseHandler() loop on ERROR_PIPE_BUSY (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/registration_protocol_win.cc » ('j') | util/win/registration_protocol_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/end_to_end_test.py
diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py
index 3bbcdb98c6a4699a0941cdc9096f8d73a4395566..8cfdd5c69bfb2db6a5117e461153b01c1ce345fe 100644
--- a/snapshot/win/end_to_end_test.py
+++ b/snapshot/win/end_to_end_test.py
@@ -21,6 +21,7 @@ import re
import subprocess
import sys
import tempfile
+import time
g_temp_dirs = []
@@ -101,6 +102,11 @@ def GetDumpFromProgram(out_dir, pipe_name, executable_name):
'--database=' + test_database
])
+ # Wait until the server is ready.
+ while not os.path.exists(pipe_name):
+ print 'Waiting for crashpad_handler to be ready...'
Mark Mentovai 2015/11/06 23:32:35 Only print this the first time. If crashpad_handle
scottmg 2015/11/06 23:53:40 Done.
+ time.sleep(0.1)
+
subprocess.call([os.path.join(out_dir, executable_name), pipe_name])
else:
subprocess.call([os.path.join(out_dir, executable_name),
« no previous file with comments | « no previous file | util/win/registration_protocol_win.cc » ('j') | util/win/registration_protocol_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698