Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1409693009: Fix leaking of RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't send IPC for the main frame. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index f596bd5bf1507daadbb6224d83f4c99d015ac95c..b15fa6ad291e19672d0e53b3aa05ed90e47f8554 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -1615,6 +1615,7 @@ bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderThreadImpl, msg)
IPC_MESSAGE_HANDLER(FrameMsg_NewFrame, OnCreateNewFrame)
+ IPC_MESSAGE_HANDLER(FrameMsg_Detach, OnDetachFrame)
IPC_MESSAGE_HANDLER(FrameMsg_NewFrameProxy, OnCreateNewFrameProxy)
IPC_MESSAGE_HANDLER(ViewMsg_SetZoomLevelForCurrentURL,
OnSetZoomLevelForCurrentURL)
@@ -1659,6 +1660,10 @@ void RenderThreadImpl::OnCreateNewFrame(FrameMsg_NewFrame_Params params) {
params.frame_owner_properties);
}
+void RenderThreadImpl::OnDetachFrame(int routing_id) {
+ RenderFrameImpl::DetachFrame(routing_id);
+}
+
void RenderThreadImpl::OnCreateNewFrameProxy(
int routing_id,
int render_view_routing_id,
« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_thread_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698