Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1409693009: Fix leaking of RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle main frame navigating to existing process. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 1f6101d375b5172ea843a7e52505c5285766a6aa..ce2ecf98f6728cd25611395dca20364bdcb2d322 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -923,6 +923,16 @@ void RenderFrameHostManager::DiscardUnusedFrame(
}
if (render_frame_host) {
+ // Clean up the unused RenderFrame in the renderer process for any
+ // subframe. The main frame is going to be cleaned up by RenderViewHost
+ // deleting RenderView, unless there are other active frames.
+ if (SiteIsolationPolicy::IsSwappedOutStateForbidden() &&
+ (render_frame_host->GetSiteInstance()->active_frame_count() > 1U ||
Charlie Reis 2015/11/04 21:28:30 Did you have a concern about this? I'm looking at
nasko 2015/12/10 21:26:52 It is coincidentally right after this - ShutdownPr
+ !frame_tree_node_->IsMainFrame())) {
+ render_frame_host->Send(
+ new FrameMsg_Detach(render_frame_host->GetRoutingID()));
+ }
+
// We won't be coming back, so delete this one.
ShutdownProxiesIfLastActiveFrameInSiteInstance(render_frame_host.get());
render_frame_host.reset();
« no previous file with comments | « no previous file | content/browser/site_per_process_browsertest.cc » ('j') | content/renderer/render_frame_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698