content/common/frame_messages.h - Issue 1409693009: Fix leaking of RenderFrames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1409693009: Fix leaking of RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on another review round. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 0e0287497e6b1a3dd437e58dd355fda0ea43c865..a290688e78eb84e334708ae7c0272436cb1504e9 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -480,6 +480,10 @@ IPC_MESSAGE_ROUTED1(FrameMsg_VisualStateRequest, uint64 /* id */)

// Instructs the renderer to create a new RenderFrame object.

IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params /* params */)

+// Instructs the renderer to detach the RenderFrame object identified by

+// |routing_id|.

+IPC_MESSAGE_CONTROL1(FrameMsg_Detach, int /* routing_id */)

// Instructs the renderer to create a new RenderFrameProxy object with

// |routing_id|. |render_view_routing_id| identifies the

// RenderView to be associated with this proxy. The new proxy's opener should