Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: content/common/frame_messages.h

Issue 1409693009: Fix leaking of RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Send Detach IPC from the RFH destructor. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for interacting with frames. 5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "cc/surfaces/surface_id.h" 8 #include "cc/surfaces/surface_id.h"
9 #include "cc/surfaces/surface_sequence.h" 9 #include "cc/surfaces/surface_sequence.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 // disowned. 503 // disowned.
504 IPC_MESSAGE_ROUTED1(FrameMsg_UpdateOpener, int /* opener_routing_id */) 504 IPC_MESSAGE_ROUTED1(FrameMsg_UpdateOpener, int /* opener_routing_id */)
505 505
506 // Requests that the RenderFrame send back a response after waiting for the 506 // Requests that the RenderFrame send back a response after waiting for the
507 // commit, activation and frame swap of the current DOM tree in blink. 507 // commit, activation and frame swap of the current DOM tree in blink.
508 IPC_MESSAGE_ROUTED1(FrameMsg_VisualStateRequest, uint64 /* id */) 508 IPC_MESSAGE_ROUTED1(FrameMsg_VisualStateRequest, uint64 /* id */)
509 509
510 // Instructs the renderer to create a new RenderFrame object. 510 // Instructs the renderer to create a new RenderFrame object.
511 IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params /* params */) 511 IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params /* params */)
512 512
513 // Instructs the renderer to detach the RenderFrame object identified by
514 // |routing_id|.
515 IPC_MESSAGE_CONTROL1(FrameMsg_Detach, int /* routing_id */)
dcheng 2015/12/11 23:40:17 I think I would personally see this as a routed me
nasko 2015/12/14 21:00:02 Done.
516
513 // Instructs the renderer to create a new RenderFrameProxy object with 517 // Instructs the renderer to create a new RenderFrameProxy object with
514 // |routing_id|. |render_view_routing_id| identifies the 518 // |routing_id|. |render_view_routing_id| identifies the
515 // RenderView to be associated with this proxy. The new proxy's opener should 519 // RenderView to be associated with this proxy. The new proxy's opener should
516 // be set to the object identified by |opener_routing_id|, or to null if that 520 // be set to the object identified by |opener_routing_id|, or to null if that
517 // is MSG_ROUTING_NONE. The new proxy should be created as a child of the 521 // is MSG_ROUTING_NONE. The new proxy should be created as a child of the
518 // object identified by |parent_routing_id| or as top level if that is 522 // object identified by |parent_routing_id| or as top level if that is
519 // MSG_ROUTING_NONE. 523 // MSG_ROUTING_NONE.
520 IPC_MESSAGE_CONTROL5(FrameMsg_NewFrameProxy, 524 IPC_MESSAGE_CONTROL5(FrameMsg_NewFrameProxy,
521 int /* routing_id */, 525 int /* routing_id */,
522 int /* render_view_routing_id */, 526 int /* render_view_routing_id */,
(...skipping 753 matching lines...) Expand 10 before | Expand all | Expand 10 after
1276 IPC_MESSAGE_ROUTED1(FrameHostMsg_ShowPopup, 1280 IPC_MESSAGE_ROUTED1(FrameHostMsg_ShowPopup,
1277 FrameHostMsg_ShowPopup_Params) 1281 FrameHostMsg_ShowPopup_Params)
1278 IPC_MESSAGE_ROUTED0(FrameHostMsg_HidePopup) 1282 IPC_MESSAGE_ROUTED0(FrameHostMsg_HidePopup)
1279 1283
1280 #endif 1284 #endif
1281 1285
1282 // Adding a new message? Stick to the sort order above: first platform 1286 // Adding a new message? Stick to the sort order above: first platform
1283 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then 1287 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then
1284 // platform independent FrameHostMsg, then ifdefs for platform specific 1288 // platform independent FrameHostMsg, then ifdefs for platform specific
1285 // FrameHostMsg. 1289 // FrameHostMsg.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698