src/objects.cc - Issue 1409613004: Use C++ implementation of Object.definePropert{y,ies}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1409613004: Use C++ implementation of Object.definePropert{y,ies} (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix fast path check when bootstrapper is active Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 2b6feb5c828b139d3ada33c35e9dcefe94d64883..5b852a2930718e830800ce7a4b0c0690ca84d324 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -6511,7 +6511,7 @@ bool JSArray::ArraySetLength(Isolate* isolate, Handle<JSArray> a,

if (!success && should_throw == THROW_ON_ERROR) {

isolate->Throw(*isolate->factory()->NewTypeError(

MessageTemplate::kStrictDeleteProperty,

- isolate->factory()->NewNumberFromUint(actual_new_len - 1)));

+ isolate->factory()->NewNumberFromUint(actual_new_len - 1), a));

}

return success;

}