Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1409613003: Fix let pattern error accumulation (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix let pattern error accumulation When the checker was added prohibiting lexical binding called let, certain error propagation was not implemented properly. This patch fixes that issue, which fixes error checking for cases such as let [let] BUG=v8:4403 R=adamk LOG=N Committed: https://crrev.com/b802051df26200c346db16e8e0b85358b57bb0e9 Cr-Commit-Position: refs/heads/master@{#31289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/expression-classifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/message/let-lexical-name-in-array-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/message/let-lexical-name-in-array-prohibited.out View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Ehrenberg
5 years, 2 months ago (2015-10-15 09:51:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409613003/1
5 years, 2 months ago (2015-10-15 09:51:38 UTC) #3
adamk
lgtm
5 years, 2 months ago (2015-10-15 09:53:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 10:41:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409613003/1
5 years, 2 months ago (2015-10-15 10:45:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 10:45:59 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 10:46:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b802051df26200c346db16e8e0b85358b57bb0e9
Cr-Commit-Position: refs/heads/master@{#31289}

Powered by Google App Engine
This is Rietveld 408576698