Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 14096026: Revert 194594 "Make sure manifest specified shortcut for Extensi..." (Closed)

Created:
7 years, 8 months ago by Finnur
Modified:
7 years, 8 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194594 "Make sure manifest specified shortcut for Extensi..." Got linker error not caught by try servers. > Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts. > > User is still free to override manually. > > BUG=226994 > TEST=Automated test included. > > Review URL: https://codereview.chromium.org/13044014 TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -277 lines) Patch
MM trunk/src/chrome/browser/extensions/api/commands/command_service.cc View 2 chunks +16 lines, -29 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/extension_keybinding_apitest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D trunk/src/chrome/browser/ui/accelerator_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/accelerator_utils_cocoa.mm View 1 chunk +0 lines, -53 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/accelerators_cocoa.h View 1 chunk +0 lines, -4 lines 0 comments Download
D trunk/src/chrome/browser/ui/gtk/accelerator_utils_gtk.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/accelerator_utils_aura.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/accelerator_utils_views.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
MM trunk/src/chrome/chrome_browser_ui.gypi View 5 chunks +2 lines, -7 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js View 1 chunk +0 lines, -11 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
7 years, 8 months ago (2013-04-17 15:46:07 UTC) #1
Finnur
7 years, 8 months ago (2013-04-17 15:46:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r194597.

Powered by Google App Engine
This is Rietveld 408576698