Issue 14096025: Revert "Accurate function prototypes for native calls from ARM simulator."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14096025: Revert "Accurate function prototypes for native calls from ARM simulator." (Closed)

Created:
7 years, 8 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 8 months ago

Reviewers:
ulan, Jakob Kummerow

CC:
v8-dev, Brad Chen

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Accurate function prototypes for native calls from ARM simulator." This reverts commit https://code.google.com/p/v8/source/detail?r=14230 The reason for revert is Win64 mksnapshot failure. Conflicts: src/arm/simulator-arm.cc BUG= Committed: https://code.google.com/p/v8/source/detail?r=14307

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -149 lines)			Patch
M	src/arguments.h	View		1 chunk	+9 lines, -12 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/simulator-arm.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View	1	5 chunks	+65 lines, -69 lines	0 comments	Download
M	src/atomicops_internals_x86_gcc.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/builtins.cc	View		1 chunk	+13 lines, -21 lines	0 comments	Download
D	src/builtins-decls.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Dmitry Lomov (no reviews)

Fixed arm build. Arm and mips tests pass.

7 years, 8 months ago (2013-04-17 13:29:50 UTC) #2

Dmitry Lomov (no reviews)

7 years, 8 months ago (2013-04-17 13:51:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14307 (presubmit successful).