Restyled Files.app's file list, including scrollbars.

Restyled Files.app's file list, including scrollbars.

This patch introduces new awesome scrollbars as well as restyles the file list, including: checkbox to the right side, removing the pinning checkbox, auto-sizing of the columns.

TEST=Run with --file-manager-new-ui. Legacy version should also not be broken.
BUG=226912
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194769

[mtomasz, 2013-04-17 05:13:16]

@yoshiki: PTAL.

[yoshiki, 2013-04-17 08:12:00]

lgtm with nits

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_table.js (right):

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:16: */
Add "@extends {cr.ui.table.TableColumnModel}".

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:120: var columnModel =
Object.create(tableColumnModelClass.prototype, {
nit: Remove a space at the head of the line.

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:245: var checkBox =
this.ownerDocument.createElement('INPUT');
nit: 'INPUT' should be in small letter for consistency.

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:272: var checkBox =
this.ownerDocument.createElement('INPUT');
ditto

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/scrollbar.js (right):

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/scrollbar.js:7: var ScrollBar =
cr.ui.define('div');
Add JSdoc.

/**
 * Creates a new scroll bar element.
 * @constructor
 * @extends {HTMLDivElement}
 */

[yoshiki, 2013-04-17 08:33:08]

By the way, can't we use CSS (-webkit-scrollbar) to implement new design
scrollbar?

[mtomasz, 2013-04-17 08:36:18]

On 2013/04/17 08:33:08, yoshiki wrote:
> By the way, can't we use CSS (-webkit-scrollbar) to implement new design
> scrollbar?

Nope, it is too limited. It supports only very small subset of css.

[mtomasz, 2013-04-17 08:52:20]

Thanks for the comments!

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_table.js (right):

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:16: */
On 2013/04/17 08:12:00, yoshiki wrote:
> Add "@extends {cr.ui.table.TableColumnModel}".

Done.

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:120: var columnModel =
Object.create(tableColumnModelClass.prototype, {
On 2013/04/17 08:12:00, yoshiki wrote:
> nit: Remove a space at the head of the line.

Done.

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:245: var checkBox =
this.ownerDocument.createElement('INPUT');
On 2013/04/17 08:12:00, yoshiki wrote:
> nit: 'INPUT' should be in small letter for consistency.

Done.

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_table.js:272: var checkBox =
this.ownerDocument.createElement('INPUT');
On 2013/04/17 08:12:00, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/scrollbar.js (right):

https://codereview.chromium.org/14096016/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/scrollbar.js:7: var ScrollBar =
cr.ui.define('div');
On 2013/04/17 08:12:00, yoshiki wrote:
> Add JSdoc.
> 
> /**
>  * Creates a new scroll bar element.
>  * @constructor
>  * @extends {HTMLDivElement}
>  */

Done.

[yoshiki, 2013-04-17 08:54:22]

On 2013/04/17 08:36:18, mtomasz wrote:
> On 2013/04/17 08:33:08, yoshiki wrote:
> > By the way, can't we use CSS (-webkit-scrollbar) to implement new design
> > scrollbar?
> 
> Nope, it is too limited. It supports only very small subset of css.

Got it. Thanks.

[commit-bot: I haz the power, 2013-04-18 01:30:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14096016/7001

[mtomasz, 2013-04-18 05:01:55]

Committed patchset #2 manually as r194769 (presubmit successful).