Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Source/WebCore/accessibility/AccessibilityListBox.cpp

Issue 14096013: Implement select element list box with shadow DOM. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@shadowselect
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/accessibility/AccessibilityListBox.cpp
diff --git a/Source/WebCore/accessibility/AccessibilityListBox.cpp b/Source/WebCore/accessibility/AccessibilityListBox.cpp
index 2ba922814348c0c5d0bbbdae4ab5d55e81771eba..c76cb1cfa6c6712974cb4597d4f058cf65f93dd7 100644
--- a/Source/WebCore/accessibility/AccessibilityListBox.cpp
+++ b/Source/WebCore/accessibility/AccessibilityListBox.cpp
@@ -130,11 +130,11 @@ void AccessibilityListBox::visibleChildren(AccessibilityChildrenVector& result)
if (!hasChildren())
addChildren();
- unsigned length = m_children.size();
- for (unsigned i = 0; i < length; i++) {
- if (toRenderListBox(m_renderer)->listIndexIsVisible(i))
- result.append(m_children[i]);
- }
+// unsigned length = m_children.size();
yosin_UTC9 2013/04/23 03:43:25 You may forget to remove this fragment.
+// for (unsigned i = 0; i < length; i++) {
+// if (toRenderListBox(m_renderer)->listIndexIsVisible(i))
+// result.append(m_children[i]);
+// }
}
AccessibilityObject* AccessibilityListBox::listBoxOptionAccessibilityObject(HTMLElement* element) const
@@ -160,19 +160,19 @@ AccessibilityObject* AccessibilityListBox::elementAccessibilityHitTest(const Int
if (!node)
return 0;
- LayoutRect parentRect = boundingBoxRect();
+// LayoutRect parentRect = boundingBoxRect();
yosin_UTC9 2013/04/23 03:43:25 You may forget to remove this fragment.
AccessibilityObject* listBoxOption = 0;
- unsigned length = m_children.size();
- for (unsigned i = 0; i < length; i++) {
- LayoutRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(parentRect.location(), i);
- // The cast to HTMLElement below is safe because the only other possible listItem type
- // would be a WMLElement, but WML builds don't use accessibility features at all.
- if (rect.contains(point)) {
- listBoxOption = m_children[i].get();
- break;
- }
- }
+// unsigned length = m_children.size();
+// for (unsigned i = 0; i < length; i++) {
+// LayoutRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(parentRect.location(), i);
+// // The cast to HTMLElement below is safe because the only other possible listItem type
+// // would be a WMLElement, but WML builds don't use accessibility features at all.
+// if (rect.contains(point)) {
+// listBoxOption = m_children[i].get();
+// break;
+// }
+// }
if (listBoxOption && !listBoxOption->accessibilityIsIgnored())
return listBoxOption;

Powered by Google App Engine
This is Rietveld 408576698