Source/WebCore/accessibility/AccessibilityListBoxOption.cpp - Issue 14096013: Implement select element list box with shadow DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/accessibility/AccessibilityListBoxOption.cpp

Issue 14096013: Implement select element list box with shadow DOM. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@shadowselect

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/accessibility/AccessibilityListBox.cpp ('k') | Source/WebCore/css/CSSValueKeywords.in » ('j') | Source/WebCore/rendering/RenderListBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/accessibility/AccessibilityListBoxOption.cpp

diff --git a/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp b/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp

index 1f87fd42542e53b18c565ff24777ab3096f6ce73..9fc115a546aa77313eca3d4fa1fd3629ee59fbe4 100644

--- a/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp

+++ b/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp

@@ -106,10 +106,10 @@ LayoutRect AccessibilityListBoxOption::elementRect() const

if (!listBoxRenderer)

return rect;

- LayoutRect parentRect = listBoxRenderer->document()->axObjectCache()->getOrCreate(listBoxRenderer)->boundingBoxRect();

- int index = listBoxOptionIndex();

- if (index != -1)

- rect = toRenderListBox(listBoxRenderer)->itemBoundingBoxRect(parentRect.location(), index);

+// LayoutRect parentRect = listBoxRenderer->document()->axObjectCache()->getOrCreate(listBoxRenderer)->boundingBoxRect();

+// int index = listBoxOptionIndex();

+// if (index != -1)

+// rect = toRenderListBox(listBoxRenderer)->itemBoundingBoxRect(parentRect.location(), index);

return rect;

}