Issue 14096010: Remove Chromium dependency on WebCore/Configurations/Version.xcconfig file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14096010: Remove Chromium dependency on WebCore/Configurations/Version.xcconfig file. (Closed)

Created:
7 years, 8 months ago by eseidel

Modified:
7 years, 8 months ago

Reviewers:
darin (slow to review), abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove Chromium dependency on WebCore/Configurations/Version.xcconfig file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194533

Patch Set 1 #

Patch Set 2 : Remove a bogus comment #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -61 lines)			Patch
	M	webkit/build/webkit_version.py	View	1	4 chunks	+12 lines, -47 lines	1 comment	Download
	M	webkit/user_agent/webkit_user_agent.gypi	View		2 chunks	+5 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

eseidel

Please review. This unblocks moving Source/WebCore to Source/core.

7 years, 8 months ago (2013-04-17 01:36:46 UTC) #1

abarth-chromium

Committed patchset #2 manually as r194533 (presubmit successful).

7 years, 8 months ago (2013-04-17 04:44:10 UTC) #5

darin (slow to review)

7 years, 8 months ago (2013-04-17 04:53:49 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/14096010/diff/4001/webkit/build/webkit_versio...
File webkit/build/webkit_version.py (right):

https://codereview.chromium.org/14096010/diff/4001/webkit/build/webkit_versio...
webkit/build/webkit_version.py:49: # would be better in a header somewhere.
yes, it'd be good to get rid of all of this build-time logic.  we should just
hard-code in user_agent_util.cc:

https://code.google.com/p/chromium/codesearch#chromium/src/webkit/user_agent/...

Expand Messages | Collapse Messages