Issue 14096008: Use content::MessageLoopRunner in a couple of Autofill tests.

Issue 14096008: Use content::MessageLoopRunner in a couple of Autofill tests. (Closed)

Created:
7 years, 8 months ago by Ilya Sherman

Modified:
7 years, 8 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use content::MessageLoopRunner in a couple of Autofill tests. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194493

Patch Set 1 #

Total comments: 4

Patch Set 2 : De-nitting #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -39 lines)			Patch
	M	components/autofill/browser/autofill_manager_unittest.cc	View	1	7 chunks	+13 lines, -20 lines	0 comments	Download
	M	components/autofill/browser/autofill_metrics_unittest.cc	View		6 chunks	+7 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

lgtm https://codereview.chromium.org/14096008/diff/1/components/autofill/browser/autofill_manager_unittest.cc File components/autofill/browser/autofill_manager_unittest.cc (right): https://codereview.chromium.org/14096008/diff/1/components/autofill/browser/autofill_manager_unittest.cc#newcode551 components/autofill/browser/autofill_manager_unittest.cc:551: // Resets the MessageLoopRunner so that it can ...

7 years, 8 months ago (2013-04-15 22:19:20 UTC) #2

groby-ooo-7-16

https://codereview.chromium.org/14096008/diff/1/components/autofill/browser/autofill_manager_unittest.cc File components/autofill/browser/autofill_manager_unittest.cc (right): https://codereview.chromium.org/14096008/diff/1/components/autofill/browser/autofill_manager_unittest.cc#newcode9 components/autofill/browser/autofill_manager_unittest.cc:9: #include "base/memory/scoped_ptr.h" Sorry, missed that the first time round ...

7 years, 8 months ago (2013-04-16 00:00:29 UTC) #3

Ilya Sherman

Thanks for catching those :) https://chromiumcodereview.appspot.com/14096008/diff/1/components/autofill/browser/autofill_manager_unittest.cc File components/autofill/browser/autofill_manager_unittest.cc (right): https://chromiumcodereview.appspot.com/14096008/diff/1/components/autofill/browser/autofill_manager_unittest.cc#newcode9 components/autofill/browser/autofill_manager_unittest.cc:9: #include "base/memory/scoped_ptr.h" On 2013/04/16 ...

7 years, 8 months ago (2013-04-16 00:57:53 UTC) #4

Ilya Sherman

7 years, 8 months ago (2013-04-17 00:09:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r194493 (presubmit successful).

Expand Messages | Collapse Messages