[api] expose API for adding per-context Intrinsics to Templates

src/api-natives.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api-natives.h"
 
 #include "src/api.h"
 #include "src/isolate-inl.h"
 #include "src/lookup.h"
 #include "src/messages.h"
@@ skipping 130 matching lines @@
     }
   }
 
  private:
   Isolate* isolate_;
   const bool disabled_;
   Handle<JSObject> obj_;
 };
 
 
+Object* GetIntrinsic(Context* context, v8::Intrinsic intrinsic) {
+  switch (intrinsic) {
+#define GET_INTRINSIC_VALUE(name, iname) \
+  case v8::k##name:                      \
+    return context->iname();
+    V8_INTRINSICS_LIST(GET_INTRINSIC_VALUE)
+#undef GET_INTRINSIC_VALUE
+  }
+  return nullptr;
+}
+
+
+Context* GetCurrentContext(Isolate* isolate) {

[Toon Verwaest, 2015/10/20 15:00:54]

This seems unnecessary given that context->iname() above will crash anyway. What
about just using isolate->native_context() in GetIntrinsic, passing the isolate
in there?

[caitp (gmail), 2015/10/20 15:38:06]

Ok

+  Context* context = isolate->context();
+  if (context != nullptr) return context->native_context();
+  return nullptr;
+}
+
+
 MaybeHandle<JSObject> ConfigureInstance(Isolate* isolate, Handle<JSObject> obj,
                                         Handle<TemplateInfo> data) {
   auto property_list = handle(data->property_list(), isolate);
   if (property_list->IsUndefined()) return obj;
   // TODO(dcarney): just use a FixedArray here.
   NeanderArray properties(property_list);
   if (properties.length() == 0) return obj;
   HandleScope scope(isolate);
   // Disable access checks while instantiating the object.
   AccessCheckDisableScope access_check_scope(isolate, obj);
 
   int i = 0;
   for (int c = 0; c < data->number_of_properties(); c++) {
     auto name = handle(Name::cast(properties.get(i++)), isolate);
-    PropertyDetails details(Smi::cast(properties.get(i++)));
-    PropertyAttributes attributes = details.attributes();
-    PropertyKind kind = details.kind();
+    auto bit = handle(properties.get(i++), isolate);
+    if (bit->IsSmi()) {
+      PropertyDetails details(Smi::cast(*bit));
+      PropertyAttributes attributes = details.attributes();
+      PropertyKind kind = details.kind();
 
-    if (kind == kData) {
-      auto prop_data = handle(properties.get(i++), isolate);
+      if (kind == kData) {
+        auto prop_data = handle(properties.get(i++), isolate);
+
+        RETURN_ON_EXCEPTION(isolate, DefineDataProperty(isolate, obj, name,
+                                                        prop_data, attributes),
+                            JSObject);
+      } else {
+        auto getter = handle(properties.get(i++), isolate);
+        auto setter = handle(properties.get(i++), isolate);
+        RETURN_ON_EXCEPTION(isolate,
+                            DefineAccessorProperty(isolate, obj, name, getter,
+                                                   setter, attributes),
+                            JSObject);
+      }
+    } else {
+      // Intrinsic data property --- Get appropriate value from the current
+      // context.
+      PropertyDetails details(Smi::cast(properties.get(i++)));
+      PropertyAttributes attributes = details.attributes();
+      DCHECK_EQ(kData, details.kind());
+
+      v8::Intrinsic intrinsic =
+          static_cast<v8::Intrinsic>(Smi::cast(properties.get(i++))->value());
+      auto prop_data =
+          handle(GetIntrinsic(GetCurrentContext(isolate), intrinsic), isolate);
 
       RETURN_ON_EXCEPTION(isolate, DefineDataProperty(isolate, obj, name,
                                                       prop_data, attributes),
                           JSObject);
-    } else {
-      auto getter = handle(properties.get(i++), isolate);
-      auto setter = handle(properties.get(i++), isolate);
-      RETURN_ON_EXCEPTION(isolate,
-                          DefineAccessorProperty(isolate, obj, name, getter,
-                                                 setter, attributes),
-                          JSObject);
     }
   }
   return obj;
 }
 
 
 MaybeHandle<JSObject> InstantiateObject(Isolate* isolate,
                                         Handle<ObjectTemplateInfo> data) {
   // Enter a new scope.  Recursion could otherwise create a lot of handles.
   HandleScope scope(isolate);
@@ skipping 178 matching lines @@
                                  Handle<Name> name, Handle<Object> value,
                                  PropertyAttributes attributes) {
   const int kSize = 3;
   PropertyDetails details(attributes, DATA, 0, PropertyCellType::kNoCell);
   auto details_handle = handle(details.AsSmi(), isolate);
   Handle<Object> data[kSize] = {name, details_handle, value};
   AddPropertyToPropertyList(isolate, info, kSize, data);
 }
 
 
+void ApiNatives::AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info,
+                                 Handle<Name> name, v8::Intrinsic intrinsic,
+                                 PropertyAttributes attributes) {
+  const int kSize = 4;
+  auto value = handle(Smi::FromInt(intrinsic), isolate);
+  auto intrinsic_marker = isolate->factory()->true_value();
+  PropertyDetails details(attributes, DATA, 0, PropertyCellType::kNoCell);
+  auto details_handle = handle(details.AsSmi(), isolate);
+  Handle<Object> data[kSize] = {name, intrinsic_marker, details_handle, value};
+  AddPropertyToPropertyList(isolate, info, kSize, data);
+}
+
+
 void ApiNatives::AddAccessorProperty(Isolate* isolate,
                                      Handle<TemplateInfo> info,
                                      Handle<Name> name, Handle<Object> getter,
                                      Handle<Object> setter,
                                      PropertyAttributes attributes) {
 #ifdef V8_JS_ACCESSORS
   DCHECK(getter.is_null() || getter->IsFunctionTemplateInfo() ||
          getter->IsJSFunction());
   DCHECK(setter.is_null() || setter->IsFunctionTemplateInfo() ||
          setter->IsJSFunction());
@@ skipping 196 matching lines @@
     Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i)));
     JSObject::SetAccessor(result, accessor).Assert();
   }
 
   DCHECK(result->shared()->IsApiFunction());
   return result;
 }
 
 }  // namespace internal
 }  // namespace v8