Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1409553003: [GN] Add solink_module tool on the Mac, Win, and GCC toolchains. (Closed)

Created:
5 years, 2 months ago by Bons
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Add solink_module tool on the Mac, Win, and GCC toolchains. For use by the loadable_module target type. BUG=369774 R=dpranke@chromium.org,brettw@chromium.org Committed: https://crrev.com/f37bc521ebc64896b346b054ebce36d0f830b68b Cr-Commit-Position: refs/heads/master@{#354195}

Patch Set 1 #

Patch Set 2 : update win and gcc toolchains as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
M build/config/BUILDCONFIG.gn View 2 chunks +5 lines, -1 line 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 1 chunk +39 lines, -0 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Bons
5 years, 2 months ago (2015-10-14 19:47:54 UTC) #1
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-14 22:28:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409553003/20001
5 years, 2 months ago (2015-10-15 00:51:30 UTC) #4
Bons
On 2015/10/14 22:28:58, Dirk Pranke wrote: > lgtm I updated the patch to include the ...
5 years, 2 months ago (2015-10-15 00:52:10 UTC) #5
brettw
lgtm
5 years, 2 months ago (2015-10-15 00:54:02 UTC) #6
Dirk Pranke
still lgtm
5 years, 2 months ago (2015-10-15 00:58:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 01:23:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409553003/20001
5 years, 2 months ago (2015-10-15 01:34:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 01:39:58 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 01:41:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f37bc521ebc64896b346b054ebce36d0f830b68b
Cr-Commit-Position: refs/heads/master@{#354195}

Powered by Google App Engine
This is Rietveld 408576698