Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 1409543004: Add a test configuration for noopt so we can add status file entries for it. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 9ec90f002715c64f17edc836b5500d806c110f8e..83fcfbe20143d7f50f496363ca147276868e236a 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -61,6 +61,7 @@ abstract class CompilerConfiguration {
bool useSdk = configuration['use_sdk'];
bool isCsp = configuration['csp'];
bool useCps = configuration['cps_ir'];
+ bool useNoopt = configuration['noopt'];
switch (compiler) {
case 'dartanalyzer':
@@ -80,7 +81,7 @@ abstract class CompilerConfiguration {
case 'none':
return new NoneCompilerConfiguration(
isDebug: isDebug, isChecked: isChecked,
- isHostChecked: isHostChecked, useSdk: useSdk);
+ isHostChecked: isHostChecked, useSdk: useSdk, useNoopt: useNoopt);
default:
throw "Unknown compiler '$compiler'";
}
@@ -136,14 +137,17 @@ abstract class CompilerConfiguration {
/// The "none" compiler.
class NoneCompilerConfiguration extends CompilerConfiguration {
+ final bool useNoopt;
+
NoneCompilerConfiguration({
bool isDebug,
bool isChecked,
bool isHostChecked,
- bool useSdk})
+ bool useSdk,
+ bool useNoopt})
: super._subclass(
isDebug: isDebug, isChecked: isChecked,
- isHostChecked: isHostChecked, useSdk: useSdk);
+ isHostChecked: isHostChecked, useSdk: useSdk), useNoopt = useNoopt;
bool get hasCompiler => false;
@@ -160,6 +164,9 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
args.add('--enable_asserts');
args.add('--enable_type_checks');
}
+ if (useNoopt) {
+ args.add('--noopt');
+ }
return args
..addAll(vmOptions)
..addAll(sharedOptions)
« no previous file with comments | « tests/lib/lib.status ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698