Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1409543004: Add a test configuration for noopt so we can add status file entries for it. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test configuration for noopt so we can add status file entries for it. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/5532a354c366876bc3ee50a3cdbf07861e1ad514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 4 chunks +10 lines, -3 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-14 17:43:11 UTC) #2
srdjan
lgtm
5 years, 2 months ago (2015-10-14 18:27:21 UTC) #3
rmacnak
5 years, 2 months ago (2015-10-14 19:36:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5532a354c366876bc3ee50a3cdbf07861e1ad514 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698