Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1409533003: Remove bogus flags from call-counts.js test. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove bogus flags from call-counts.js test. The runtime flag in question makes no sense, because the feature cannot be disabled without keeping the snapshot in sync. We should avoid having the flag in our "mjsunit" test suite, so that CluserFuzz doesn't pick it up. The test in question is already skipped, the change will not affect test results on our waterfall. R=mvstanton@chromium.org TEST=mjsunit/call-counts BUG=v8:4458 LOG=n Committed: https://crrev.com/2aba89e3362f1ab435b3041ea67b442cf258f9b1 Cr-Commit-Position: refs/heads/master@{#31302}

Patch Set 1 #

Patch Set 2 : Also fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/mjsunit/call-counts.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-15 12:30:38 UTC) #1
mvstanton
lgtm, thanks!
5 years, 2 months ago (2015-10-15 12:31:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409533003/20001
5 years, 2 months ago (2015-10-15 12:34:42 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 13:31:42 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 13:32:08 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2aba89e3362f1ab435b3041ea67b442cf258f9b1
Cr-Commit-Position: refs/heads/master@{#31302}

Powered by Google App Engine
This is Rietveld 408576698