Trace through const objects instead of spying on flow graph construction to find closure functions.…

Trace through const objects instead of spying on flow graph construction to find closure functions. Allows dropping local closure functions the optimizing compiler removes.

Remove a dead local function from Uri.parse.

Don't rely on HasCode to indicate a function's callees have been visited because it misses functions compiled by const evaluation.

Add missing VM entry point.

dart2js ARM
libprecompiled.so -2.7%
precompiled.isolate -3.4%

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/a9fcf0ee8b20d94ff886bc5ff55954c989a36e6d

[rmacnak, 2015-10-14 20:50:15]

rmacnak@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-10-14 21:04:11]

lgtm

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:418: if (!instance.raw()->IsHeapObject()) return;
Maybe more readable: if (instance.IsSmi()) return;

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:419: if (!instance.IsCanonical()) return;
Add brief comment when that is the case.

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:421: class ConstObjectVisitor : public
ObjectPointerVisitor {
We typically add classes outside the scope of a function, but I do not care that
much.

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:426: subinstance_(Object::Handle()) {}
4 spaces indent.

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:434: }
clear subinstance_ to null (so that it does not hold onto an object)?

[rmacnak, 2015-10-14 22:22:41]

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:418: if (!instance.raw()->IsHeapObject()) return;
On 2015/10/14 21:04:11, srdjan wrote:
> Maybe more readable: if (instance.IsSmi()) return;

Done.

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:419: if (!instance.IsCanonical()) return;
On 2015/10/14 21:04:11, srdjan wrote:
> Add brief comment when that is the case.

Done.

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:426: subinstance_(Object::Handle()) {}
On 2015/10/14 21:04:11, srdjan wrote:
> 4 spaces indent.

Done.

https://codereview.chromium.org/1409523003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:434: }
On 2015/10/14 21:04:11, srdjan wrote:
> clear subinstance_ to null (so that it does not hold onto an object)?

Done.

[rmacnak, 2015-10-14 22:30:48]

Committed patchset #3 (id:40001) manually as
a9fcf0ee8b20d94ff886bc5ff55954c989a36e6d (presubmit successful).