Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 14095009: Android: Fix up video to work with mailboxes. (Closed)

Created:
7 years, 8 months ago by no sievers
Modified:
7 years, 8 months ago
CC:
chromium-reviews, apatrick_chromium, danakj, qinmin
Visibility:
Public.

Description

Android: Fix up video to work with mailboxes. Change Consume/ProduceTexture to use the same texture target validator as BindTexture(). Otherwise, external and rectangle textures will fail this call, since we exclude these targets from the wider GL APIs using the texture_target validator Also, pass stream texture flag along and reset it to |false| after Produce() since the new GL texture will be disconnected from the stream. BUG=230327, 179729 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194668

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -17 lines) Patch
M content/common/gpu/texture_image_transport_surface.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 4 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 6 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
no sievers
I think the validator change affects rectangular textures as well, which were probably failing Consume/Produce ...
7 years, 8 months ago (2013-04-13 02:57:28 UTC) #1
piman
https://codereview.chromium.org/14095009/diff/1/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/14095009/diff/1/gpu/command_buffer/service/texture_manager.cc#newcode1023 gpu/command_buffer/service/texture_manager.cc:1023: definition->min_filter() != GL_LINEAR) { Is this needed? We checked ...
7 years, 8 months ago (2013-04-13 17:11:36 UTC) #2
no sievers
https://codereview.chromium.org/14095009/diff/1/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/14095009/diff/1/gpu/command_buffer/service/texture_manager.cc#newcode1023 gpu/command_buffer/service/texture_manager.cc:1023: definition->min_filter() != GL_LINEAR) { On 2013/04/13 17:11:36, piman wrote: ...
7 years, 8 months ago (2013-04-15 17:33:44 UTC) #3
piman
https://codereview.chromium.org/14095009/diff/5001/gpu/command_buffer/service/texture_definition.h File gpu/command_buffer/service/texture_definition.h (right): https://codereview.chromium.org/14095009/diff/5001/gpu/command_buffer/service/texture_definition.h#newcode74 gpu/command_buffer/service/texture_definition.h:74: void SetStreamTexture() { stream_texture_ = true; } Should this ...
7 years, 8 months ago (2013-04-15 17:47:54 UTC) #4
no sievers
https://codereview.chromium.org/14095009/diff/5001/gpu/command_buffer/service/texture_definition.h File gpu/command_buffer/service/texture_definition.h (right): https://codereview.chromium.org/14095009/diff/5001/gpu/command_buffer/service/texture_definition.h#newcode74 gpu/command_buffer/service/texture_definition.h:74: void SetStreamTexture() { stream_texture_ = true; } On 2013/04/15 ...
7 years, 8 months ago (2013-04-15 18:54:30 UTC) #5
piman
LGTM, thanks!
7 years, 8 months ago (2013-04-15 19:02:36 UTC) #6
no sievers
7 years, 8 months ago (2013-04-17 21:00:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r194668 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698