Issue 1409483002: dart2js cps: Speed up CPS IR integrity checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409483002: dart2js cps: Speed up CPS IR integrity checker. (Closed)

Created:
5 years, 2 months ago by asgerf

Modified:
5 years, 2 months ago

Reviewers:
Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Speed up CPS IR integrity checker. Building large maps and sets slowed the checker down a lot, so it has been narrowed down to one map. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/fd3b1d144fc8e1dc8c055e60ce63564839ae9b62

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -75 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart	View	9 chunks	+63 lines, -47 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/insert_refinements.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View	3 chunks	+33 lines, -26 lines	0 comments	Download

Total messages: 6 (2 generated)

asgerf

5 years, 2 months ago (2015-10-15 09:01:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fd3b1d144fc8e1dc8c055e60ce63564839ae9b62 (presubmit successful).