chrome/browser/resources/md_downloads/item.html - Issue 1409473002: MD Downloads: replace <paper-icon-button> with <inky-text-button>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/item.html

Issue 1409473002: MD Downloads: replace <paper-icon-button> with <inky-text-button> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iron-list3

Patch Set: crisp Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_downloads/item.css ('k') | chrome/browser/resources/md_downloads/item.js » ('j') | chrome/browser/resources/md_downloads/item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_downloads/item.html

diff --git a/chrome/browser/resources/md_downloads/item.html b/chrome/browser/resources/md_downloads/item.html

index faef7518c5ea8d48282d1bc35a62b2cb6d418595..635d604da136762ebe9f237cd65494c27f94c043 100644

--- a/chrome/browser/resources/md_downloads/item.html

+++ b/chrome/browser/resources/md_downloads/item.html

@@ -7,6 +7,7 @@

+<link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripple.html">

@@ -91,10 +92,10 @@

</div>

- <paper-icon-button id="remove" icon="clear"

- i18n-values="title:controlRemoveFromList"

+ <div id="remove" tabindex="0" i18n-values="title:controlRemoveFromList"

style$="[[computeRemoveStyle_(isDangerous_, showCancel_)]]"

- on-tap="onRemoveTap_"></paper-icon-button>

+ on-focus="activateRipple_" on-blur="deactivateRipple_"

esprehn 2015/10/15 04:53:20 put the on-blur on the next line?

+ on-tap="onRemoveTap_">✕</div>

Dan Beam 2015/10/14 04:57:10 this broke on-tap for focus + Enter from keyboard.

</div>

<div id="incognito" i18n-values="title:inIncognito"