MD Downloads: replace <paper-icon-button> with <inky-text-button>

MD Downloads: replace <paper-icon-button> with <inky-text-button>

This shaves ~20 x (<iron-icon> + SVG).

R=sorvell@google.com,esprehn@chromium.org
BUG=526577, 526583
NOPRESUBMIT=true  # because crisper.js

Committed: https://crrev.com/615011176d09fd5461eb0424b8602254efeefeab
Cr-Commit-Position: refs/heads/master@{#354465}

[Dan Beam, 2015-10-14 04:51:12]

dbeam@chromium.org changed reviewers:
+ esprehn@chromium.org, sorvell@google.com
- sorvell@chromium.org

[Dan Beam, 2015-10-14 04:51:27]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-10-14 04:56:33]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2015-10-14 04:57:10]

Hey Steve,

I think this is a little more straight-forward than ink-icon-button with a
similar approach.

-- Dan

https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.html:98:
on-tap="onRemoveTap_">&#x2715;</div>
this broke on-tap for focus + Enter from keyboard.  need to figure out why...

[sorvell, 2015-10-14 21:53:08]

On 2015/10/14 04:57:10, Dan Beam wrote:
> Hey Steve,
> 
> I think this is a little more straight-forward than ink-icon-button with a
> similar approach.
> 
> -- Dan
> 
>
https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/md_downloads/item.html (right):
> 
>
https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
> chrome/browser/resources/md_downloads/item.html:98:
> on-tap="onRemoveTap_">&#x2715;</div>
> this broke on-tap for focus + Enter from keyboard.  need to figure out why...

That seems fine and it should be slightly faster this way.

[Dan Beam, 2015-10-15 04:40:39]

ping esprehn@

[esprehn, 2015-10-15 04:53:21]

lgtm w/ nits fixed

https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.html:97: on-focus="activateRipple_"
on-blur="deactivateRipple_"
put the on-blur on the next line?

https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/1409473002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.js:108:
this.removeRipple_.setAttribute('center', '');
.center = true I think is better than going through the attribute

https://codereview.chromium.org/1409473002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.html (right):

https://codereview.chromium.org/1409473002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.html:96: on-focus="activateRipple_"
on-blur="deactivateRipple_"
on-blur on its own line

https://codereview.chromium.org/1409473002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/1409473002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.js:108:
this.removeRipple_.setAttribute('center', '');
.center = true

[Dan Beam, 2015-10-16 04:40:37]

Patchset #3 (id:80001) has been deleted

[Dan Beam, 2015-10-16 04:43:44]

so I did all of Elliot's nits and looked into how to make this act similarly to
other buttons.

I talked with dfreedm@ about the a11y aspect and started porting over behavior
from various levels (started with IronA11yKeyBehavior, then moved to other Iron
things, then Paper things, and finally found PaperInkyFocusBehavior).

I think it's probably for the best to just re-use Polymer.PaperInkyFocusBehavior
for now as it's got a better chance of not having lots of a11y bugs and
differing from the platform.

that said: please take another look.  this still saves us # items rendered x
(<iron-icon> + SVG).

[esprehn, 2015-10-16 04:47:57]

lgtm yay

[Dan Beam, 2015-10-16 07:48:09]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-10-16 07:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409473002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409473002/120001

[commit-bot: I haz the power, 2015-10-16 07:50:39]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-10-16 07:51:38]

Patchset 4 (id:??) landed as
https://crrev.com/615011176d09fd5461eb0424b8602254efeefeab
Cr-Commit-Position: refs/heads/master@{#354465}