Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1409433002: Disable state saving for TextViewWithClickableSpans. (Closed)

Created:
5 years, 2 months ago by aurimas (slooooooooow)
Modified:
5 years, 2 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable state saving for TextViewWithClickableSpans. BUG=533362 Committed: https://crrev.com/80d2629712594ab6b705794b98589d2ccc0419f1 Cr-Commit-Position: refs/heads/master@{#353912}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aurimas (slooooooooow)
PTAL
5 years, 2 months ago (2015-10-13 22:04:14 UTC) #2
newt (away)
lgtm with a comment on the comment https://chromiumcodereview.appspot.com/1409433002/diff/1/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java File ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java (right): https://chromiumcodereview.appspot.com/1409433002/diff/1/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java#newcode49 ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java:49: // Android ...
5 years, 2 months ago (2015-10-13 22:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409433002/20001
5 years, 2 months ago (2015-10-13 22:13:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 23:49:05 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:50:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80d2629712594ab6b705794b98589d2ccc0419f1
Cr-Commit-Position: refs/heads/master@{#353912}

Powered by Google App Engine
This is Rietveld 408576698