Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/code-stubs.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: A few more fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/disassembler.cc » ('j') | src/full-codegen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index f19258bb46c42df3e2647bca0099fafb37f7f8c7..59da7e7f99d5484940828111399485b64a37091a 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1088,8 +1088,8 @@ class KeyedArrayCallStub: public HICStub {
}
class ContextualBits: public BitField<bool, 0, 1> {};
- STATIC_ASSERT(IC::Contextual::kShift == ContextualBits::kShift);
- STATIC_ASSERT(IC::Contextual::kSize == ContextualBits::kSize);
+ STATIC_ASSERT(LoadIC::Contextual::kShift == ContextualBits::kShift);
mvstanton 2014/01/17 09:47:51 Toon, any insight into whats going on here? This a
Toon Verwaest 2014/01/17 10:05:56 This should be removed as well. This is a call IC
mvstanton 2014/01/17 10:44:33 Done. I kept asserts that indicate bit 0 is "busy,
+ STATIC_ASSERT(LoadIC::Contextual::kSize == ContextualBits::kSize);
class HoleyBits: public BitField<bool, 1, 1> {};
STATIC_ASSERT(Code::kArgumentsBits <= kStubMinorKeyBits - 2);
class ArgcBits: public BitField<int, 2, Code::kArgumentsBits> {};
« no previous file with comments | « no previous file | src/disassembler.cc » ('j') | src/full-codegen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698