src/disassembler.cc - Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/disassembler.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ports and addressed comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/disassembler.cc

diff --git a/src/disassembler.cc b/src/disassembler.cc

index 5a4a93c6eefaedc7f7c3ada65617b7c058209e83..7f3ee19f8410c4f1598f70c780908f4eabe252f3 100644

--- a/src/disassembler.cc

+++ b/src/disassembler.cc

@@ -237,7 +237,8 @@ static int DecodeIt(Isolate* isolate,

Code* code = Code::GetCodeFromTargetAddress(relocinfo.target_address());

Code::Kind kind = code->kind();

if (code->is_inline_cache_stub()) {

- if (code->IsContextual()) {

+ if (kind == Code::LOAD_IC &&

+ LoadIC::GetContextualMode(code->extra_ic_state()) == CONTEXTUAL) {

out.AddFormatted(" contextual,");

}

InlineCacheState ic_state = code->ic_state();

« no previous file with comments | « src/code-stubs.h ('k') | src/full-codegen.cc » ('j') | no next file with comments »