Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Side by Side Diff: src/code-stubs.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed commented out assert. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/disassembler.cc » ('j') | src/ia32/lithium-codegen-ia32.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
1081 CodeStubInterfaceDescriptor* descriptor); 1081 CodeStubInterfaceDescriptor* descriptor);
1082 1082
1083 virtual Handle<Code> GenerateCode(Isolate* isolate); 1083 virtual Handle<Code> GenerateCode(Isolate* isolate);
1084 1084
1085 private: 1085 private:
1086 virtual int NotMissMinorKey() { 1086 virtual int NotMissMinorKey() {
1087 return GetExtraICState() | ArgcBits::encode(argc_); 1087 return GetExtraICState() | ArgcBits::encode(argc_);
1088 } 1088 }
1089 1089
1090 class ContextualBits: public BitField<bool, 0, 1> {}; 1090 class ContextualBits: public BitField<bool, 0, 1> {};
1091 STATIC_ASSERT(IC::Contextual::kShift == ContextualBits::kShift); 1091 STATIC_ASSERT(LoadIC::Contextual::kShift == ContextualBits::kShift);
1092 STATIC_ASSERT(IC::Contextual::kSize == ContextualBits::kSize); 1092 STATIC_ASSERT(LoadIC::Contextual::kSize == ContextualBits::kSize);
1093 class HoleyBits: public BitField<bool, 1, 1> {}; 1093 class HoleyBits: public BitField<bool, 1, 1> {};
1094 STATIC_ASSERT(Code::kArgumentsBits <= kStubMinorKeyBits - 2); 1094 STATIC_ASSERT(Code::kArgumentsBits <= kStubMinorKeyBits - 2);
1095 class ArgcBits: public BitField<int, 2, Code::kArgumentsBits> {}; 1095 class ArgcBits: public BitField<int, 2, Code::kArgumentsBits> {};
1096 virtual CodeStub::Major MajorKey() { return KeyedArrayCall; } 1096 virtual CodeStub::Major MajorKey() { return KeyedArrayCall; }
1097 int bit_field_; 1097 int bit_field_;
1098 int argc_; 1098 int argc_;
1099 }; 1099 };
1100 1100
1101 1101
1102 class BinaryOpICStub : public HydrogenCodeStub { 1102 class BinaryOpICStub : public HydrogenCodeStub {
(...skipping 1366 matching lines...) Expand 10 before | Expand all | Expand 10 after
2469 2469
2470 2470
2471 class CallDescriptors { 2471 class CallDescriptors {
2472 public: 2472 public:
2473 static void InitializeForIsolate(Isolate* isolate); 2473 static void InitializeForIsolate(Isolate* isolate);
2474 }; 2474 };
2475 2475
2476 } } // namespace v8::internal 2476 } } // namespace v8::internal
2477 2477
2478 #endif // V8_CODE_STUBS_H_ 2478 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « no previous file | src/disassembler.cc » ('j') | src/ia32/lithium-codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698