Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Side by Side Diff: src/x64/lithium-x64.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 V(Return) \ 151 V(Return) \
152 V(SeqStringGetChar) \ 152 V(SeqStringGetChar) \
153 V(SeqStringSetChar) \ 153 V(SeqStringSetChar) \
154 V(ShiftI) \ 154 V(ShiftI) \
155 V(SmiTag) \ 155 V(SmiTag) \
156 V(SmiUntag) \ 156 V(SmiUntag) \
157 V(StackCheck) \ 157 V(StackCheck) \
158 V(StoreCodeEntry) \ 158 V(StoreCodeEntry) \
159 V(StoreContextSlot) \ 159 V(StoreContextSlot) \
160 V(StoreGlobalCell) \ 160 V(StoreGlobalCell) \
161 V(StoreGlobalGeneric) \
162 V(StoreKeyed) \ 161 V(StoreKeyed) \
163 V(StoreKeyedGeneric) \ 162 V(StoreKeyedGeneric) \
164 V(StoreNamedField) \ 163 V(StoreNamedField) \
165 V(StoreNamedGeneric) \ 164 V(StoreNamedGeneric) \
166 V(StringAdd) \ 165 V(StringAdd) \
167 V(StringCharCodeAt) \ 166 V(StringCharCodeAt) \
168 V(StringCharFromCode) \ 167 V(StringCharFromCode) \
169 V(StringCompareAndBranch) \ 168 V(StringCompareAndBranch) \
170 V(SubI) \ 169 V(SubI) \
171 V(TaggedToI) \ 170 V(TaggedToI) \
(...skipping 1426 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 } 1597 }
1599 1598
1600 LOperand* value() { return inputs_[0]; } 1599 LOperand* value() { return inputs_[0]; }
1601 LOperand* temp() { return temps_[0]; } 1600 LOperand* temp() { return temps_[0]; }
1602 1601
1603 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell") 1602 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell")
1604 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell) 1603 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell)
1605 }; 1604 };
1606 1605
1607 1606
1608 class LStoreGlobalGeneric V8_FINAL : public LTemplateInstruction<0, 3, 0> {
1609 public:
1610 explicit LStoreGlobalGeneric(LOperand* context,
1611 LOperand* global_object,
1612 LOperand* value) {
1613 inputs_[0] = context;
1614 inputs_[1] = global_object;
1615 inputs_[2] = value;
1616 }
1617
1618 LOperand* context() { return inputs_[0]; }
1619 LOperand* global_object() { return inputs_[1]; }
1620 LOperand* value() { return inputs_[2]; }
1621
1622 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalGeneric, "store-global-generic")
1623 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalGeneric)
1624
1625 Handle<Object> name() const { return hydrogen()->name(); }
1626 StrictModeFlag strict_mode_flag() { return hydrogen()->strict_mode_flag(); }
1627 };
1628
1629
1630 class LLoadContextSlot V8_FINAL : public LTemplateInstruction<1, 1, 0> { 1607 class LLoadContextSlot V8_FINAL : public LTemplateInstruction<1, 1, 0> {
1631 public: 1608 public:
1632 explicit LLoadContextSlot(LOperand* context) { 1609 explicit LLoadContextSlot(LOperand* context) {
1633 inputs_[0] = context; 1610 inputs_[0] = context;
1634 } 1611 }
1635 1612
1636 LOperand* context() { return inputs_[0]; } 1613 LOperand* context() { return inputs_[0]; }
1637 1614
1638 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1615 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1639 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1616 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 1122 matching lines...) Expand 10 before | Expand all | Expand 10 after
2762 2739
2763 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2740 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2764 }; 2741 };
2765 2742
2766 #undef DECLARE_HYDROGEN_ACCESSOR 2743 #undef DECLARE_HYDROGEN_ACCESSOR
2767 #undef DECLARE_CONCRETE_INSTRUCTION 2744 #undef DECLARE_CONCRETE_INSTRUCTION
2768 2745
2769 } } // namespace v8::int 2746 } } // namespace v8::int
2770 2747
2771 #endif // V8_X64_LITHIUM_X64_H_ 2748 #endif // V8_X64_LITHIUM_X64_H_
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698