Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/regress/regress-is-contextual.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1930 matching lines...) Expand 10 before | Expand all | Expand 10 after
1941 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1941 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1942 LOperand* value = UseRegister(instr->value()); 1942 LOperand* value = UseRegister(instr->value());
1943 // Use a temp to avoid reloading the cell value address in the case where 1943 // Use a temp to avoid reloading the cell value address in the case where
1944 // we perform a hole check. 1944 // we perform a hole check.
1945 return instr->RequiresHoleCheck() 1945 return instr->RequiresHoleCheck()
1946 ? AssignEnvironment(new(zone()) LStoreGlobalCell(value, TempRegister())) 1946 ? AssignEnvironment(new(zone()) LStoreGlobalCell(value, TempRegister()))
1947 : new(zone()) LStoreGlobalCell(value, NULL); 1947 : new(zone()) LStoreGlobalCell(value, NULL);
1948 } 1948 }
1949 1949
1950 1950
1951 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1952 LOperand* context = UseFixed(instr->context(), rsi);
1953 LOperand* global_object = UseFixed(instr->global_object(), rdx);
1954 LOperand* value = UseFixed(instr->value(), rax);
1955 LStoreGlobalGeneric* result =
1956 new(zone()) LStoreGlobalGeneric(context, global_object, value);
1957 return MarkAsCall(result, instr);
1958 }
1959
1960
1961 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 1951 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
1962 LOperand* context = UseRegisterAtStart(instr->value()); 1952 LOperand* context = UseRegisterAtStart(instr->value());
1963 LInstruction* result = 1953 LInstruction* result =
1964 DefineAsRegister(new(zone()) LLoadContextSlot(context)); 1954 DefineAsRegister(new(zone()) LLoadContextSlot(context));
1965 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 1955 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
1966 } 1956 }
1967 1957
1968 1958
1969 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) { 1959 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
1970 LOperand* context; 1960 LOperand* context;
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
2502 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2492 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2503 LOperand* object = UseRegister(instr->object()); 2493 LOperand* object = UseRegister(instr->object());
2504 LOperand* index = UseTempRegister(instr->index()); 2494 LOperand* index = UseTempRegister(instr->index());
2505 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2495 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2506 } 2496 }
2507 2497
2508 2498
2509 } } // namespace v8::internal 2499 } } // namespace v8::internal
2510 2500
2511 #endif // V8_TARGET_ARCH_X64 2501 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/regress/regress-is-contextual.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698