Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: src/x64/ic-x64.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1327 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 1338
1339 1339
1340 void LoadIC::GenerateMegamorphic(MacroAssembler* masm, ContextualMode mode) { 1340 void LoadIC::GenerateMegamorphic(MacroAssembler* masm, ContextualMode mode) {
1341 // ----------- S t a t e ------------- 1341 // ----------- S t a t e -------------
1342 // -- rax : receiver 1342 // -- rax : receiver
1343 // -- rcx : name 1343 // -- rcx : name
1344 // -- rsp[0] : return address 1344 // -- rsp[0] : return address
1345 // ----------------------------------- 1345 // -----------------------------------
1346 1346
1347 // Probe the stub cache. 1347 // Probe the stub cache.
1348 ExtraICState extra_ic_state = IC::ComputeExtraICState(mode); 1348 ExtraICState extra_ic_state = LoadIC::ComputeExtraICState(mode);
1349 Code::Flags flags = Code::ComputeFlags( 1349 Code::Flags flags = Code::ComputeFlags(
1350 Code::HANDLER, MONOMORPHIC, extra_ic_state, 1350 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1351 Code::NORMAL, Code::LOAD_IC); 1351 Code::NORMAL, Code::LOAD_IC);
1352 masm->isolate()->stub_cache()->GenerateProbe( 1352 masm->isolate()->stub_cache()->GenerateProbe(
1353 masm, flags, rax, rcx, rbx, rdx); 1353 masm, flags, rax, rcx, rbx, rdx);
1354 1354
1355 GenerateMiss(masm); 1355 GenerateMiss(masm);
1356 } 1356 }
1357 1357
1358 1358
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
1691 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1691 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1692 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1692 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1693 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1693 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1694 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1694 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1695 } 1695 }
1696 1696
1697 1697
1698 } } // namespace v8::internal 1698 } } // namespace v8::internal
1699 1699
1700 #endif // V8_TARGET_ARCH_X64 1700 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698