Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: src/stub-cache.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/proxy.js ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 MacroAssembler* masm() { return &masm_; } 510 MacroAssembler* masm() { return &masm_; }
511 void set_failure(Failure* failure) { failure_ = failure; } 511 void set_failure(Failure* failure) { failure_ = failure; }
512 512
513 static void LookupPostInterceptor(Handle<JSObject> holder, 513 static void LookupPostInterceptor(Handle<JSObject> holder,
514 Handle<Name> name, 514 Handle<Name> name,
515 LookupResult* lookup); 515 LookupResult* lookup);
516 516
517 Isolate* isolate() { return isolate_; } 517 Isolate* isolate() { return isolate_; }
518 Heap* heap() { return isolate()->heap(); } 518 Heap* heap() { return isolate()->heap(); }
519 Factory* factory() { return isolate()->factory(); } 519 Factory* factory() { return isolate()->factory(); }
520 ContextualMode contextual_mode() {
521 return IC::GetContextualMode(extra_state());
522 }
523 520
524 static void GenerateTailCall(MacroAssembler* masm, Handle<Code> code); 521 static void GenerateTailCall(MacroAssembler* masm, Handle<Code> code);
525 522
526 private: 523 private:
527 Isolate* isolate_; 524 Isolate* isolate_;
528 const ExtraICState extra_ic_state_; 525 const ExtraICState extra_ic_state_;
529 MacroAssembler masm_; 526 MacroAssembler masm_;
530 Failure* failure_; 527 Failure* failure_;
531 }; 528 };
532 529
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 677
681 Handle<Code> CompileLoadGlobal(Handle<Type> type, 678 Handle<Code> CompileLoadGlobal(Handle<Type> type,
682 Handle<GlobalObject> holder, 679 Handle<GlobalObject> holder,
683 Handle<PropertyCell> cell, 680 Handle<PropertyCell> cell,
684 Handle<Name> name, 681 Handle<Name> name,
685 bool is_dont_delete); 682 bool is_dont_delete);
686 683
687 static Register* registers(); 684 static Register* registers();
688 685
689 protected: 686 protected:
687 ContextualMode contextual_mode() {
688 return LoadIC::GetContextualMode(extra_state());
689 }
690
690 virtual Register HandlerFrontendHeader(Handle<Type> type, 691 virtual Register HandlerFrontendHeader(Handle<Type> type,
691 Register object_reg, 692 Register object_reg,
692 Handle<JSObject> holder, 693 Handle<JSObject> holder,
693 Handle<Name> name, 694 Handle<Name> name,
694 Label* miss); 695 Label* miss);
695 696
696 virtual void HandlerFrontendFooter(Handle<Name> name, Label* miss); 697 virtual void HandlerFrontendFooter(Handle<Name> name, Label* miss);
697 698
698 Register CallbackHandlerFrontend(Handle<Type> type, 699 Register CallbackHandlerFrontend(Handle<Type> type,
699 Register object_reg, 700 Register object_reg,
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1073 Handle<JSFunction> constant_function_; 1074 Handle<JSFunction> constant_function_;
1074 bool is_simple_api_call_; 1075 bool is_simple_api_call_;
1075 Handle<FunctionTemplateInfo> expected_receiver_type_; 1076 Handle<FunctionTemplateInfo> expected_receiver_type_;
1076 Handle<CallHandlerInfo> api_call_info_; 1077 Handle<CallHandlerInfo> api_call_info_;
1077 }; 1078 };
1078 1079
1079 1080
1080 } } // namespace v8::internal 1081 } } // namespace v8::internal
1081 1082
1082 #endif // V8_STUB_CACHE_H_ 1083 #endif // V8_STUB_CACHE_H_
OLDNEW
« no previous file with comments | « src/proxy.js ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698