Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/objects.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5122 matching lines...) Expand 10 before | Expand all | Expand 10 after
5133 inline ExtraICState extended_extra_ic_state(); // Only valid for 5133 inline ExtraICState extended_extra_ic_state(); // Only valid for
5134 // non-call IC stubs. 5134 // non-call IC stubs.
5135 static bool needs_extended_extra_ic_state(Kind kind) { 5135 static bool needs_extended_extra_ic_state(Kind kind) {
5136 // TODO(danno): This is a bit of a hack right now since there are still 5136 // TODO(danno): This is a bit of a hack right now since there are still
5137 // clients of this API that pass "extra" values in for argc. These clients 5137 // clients of this API that pass "extra" values in for argc. These clients
5138 // should be retrofitted to used ExtendedExtraICState. 5138 // should be retrofitted to used ExtendedExtraICState.
5139 return kind == COMPARE_NIL_IC || kind == TO_BOOLEAN_IC || 5139 return kind == COMPARE_NIL_IC || kind == TO_BOOLEAN_IC ||
5140 kind == BINARY_OP_IC; 5140 kind == BINARY_OP_IC;
5141 } 5141 }
5142 5142
5143 bool IsContextual(); // Only valid for IC stubs.
5144 inline StubType type(); // Only valid for monomorphic IC stubs. 5143 inline StubType type(); // Only valid for monomorphic IC stubs.
5145 inline int arguments_count(); // Only valid for call IC stubs. 5144 inline int arguments_count(); // Only valid for call IC stubs.
5146 5145
5147 // Testers for IC stub kinds. 5146 // Testers for IC stub kinds.
5148 inline bool is_inline_cache_stub(); 5147 inline bool is_inline_cache_stub();
5149 inline bool is_debug_stub(); 5148 inline bool is_debug_stub();
5150 inline bool is_handler() { return kind() == HANDLER; } 5149 inline bool is_handler() { return kind() == HANDLER; }
5151 inline bool is_load_stub() { return kind() == LOAD_IC; } 5150 inline bool is_load_stub() { return kind() == LOAD_IC; }
5152 inline bool is_keyed_load_stub() { return kind() == KEYED_LOAD_IC; } 5151 inline bool is_keyed_load_stub() { return kind() == KEYED_LOAD_IC; }
5153 inline bool is_store_stub() { return kind() == STORE_IC; } 5152 inline bool is_store_stub() { return kind() == STORE_IC; }
(...skipping 5504 matching lines...) Expand 10 before | Expand all | Expand 10 after
10658 } else { 10657 } else {
10659 value &= ~(1 << bit_position); 10658 value &= ~(1 << bit_position);
10660 } 10659 }
10661 return value; 10660 return value;
10662 } 10661 }
10663 }; 10662 };
10664 10663
10665 } } // namespace v8::internal 10664 } } // namespace v8::internal
10666 10665
10667 #endif // V8_OBJECTS_H_ 10666 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698