Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/promise.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10810 matching lines...) Expand 10 before | Expand all | Expand 10 after
10821 Address code_start_address = instruction_start(); 10821 Address code_start_address = instruction_start();
10822 for (int i = 0; i < deopt_data->DeoptCount(); i++) { 10822 for (int i = 0; i < deopt_data->DeoptCount(); i++) {
10823 if (deopt_data->Pc(i)->value() == -1) continue; 10823 if (deopt_data->Pc(i)->value() == -1) continue;
10824 Address address = code_start_address + deopt_data->Pc(i)->value(); 10824 Address address = code_start_address + deopt_data->Pc(i)->value();
10825 if (address == pc) return true; 10825 if (address == pc) return true;
10826 } 10826 }
10827 return false; 10827 return false;
10828 } 10828 }
10829 10829
10830 10830
10831 bool Code::IsContextual() {
10832 ASSERT(is_inline_cache_stub());
10833 Kind kind = this->kind();
10834 if (kind == STORE_IC || kind == LOAD_IC || kind == CALL_IC) {
10835 ExtraICState extra_state = extra_ic_state();
10836 return IC::GetContextualMode(extra_state) == CONTEXTUAL;
10837 }
10838 return false;
10839 }
10840
10841
10842 // Identify kind of code. 10831 // Identify kind of code.
10843 const char* Code::Kind2String(Kind kind) { 10832 const char* Code::Kind2String(Kind kind) {
10844 switch (kind) { 10833 switch (kind) {
10845 #define CASE(name) case name: return #name; 10834 #define CASE(name) case name: return #name;
10846 CODE_KIND_LIST(CASE) 10835 CODE_KIND_LIST(CASE)
10847 #undef CASE 10836 #undef CASE
10848 case NUMBER_OF_KINDS: break; 10837 case NUMBER_OF_KINDS: break;
10849 } 10838 }
10850 UNREACHABLE(); 10839 UNREACHABLE();
10851 return NULL; 10840 return NULL;
(...skipping 5795 matching lines...) Expand 10 before | Expand all | Expand 10 after
16647 #define ERROR_MESSAGES_TEXTS(C, T) T, 16636 #define ERROR_MESSAGES_TEXTS(C, T) T,
16648 static const char* error_messages_[] = { 16637 static const char* error_messages_[] = {
16649 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16638 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16650 }; 16639 };
16651 #undef ERROR_MESSAGES_TEXTS 16640 #undef ERROR_MESSAGES_TEXTS
16652 return error_messages_[reason]; 16641 return error_messages_[reason];
16653 } 16642 }
16654 16643
16655 16644
16656 } } // namespace v8::internal 16645 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/promise.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698