Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: src/mips/lithium-mips.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 V(Return) \ 152 V(Return) \
153 V(SeqStringGetChar) \ 153 V(SeqStringGetChar) \
154 V(SeqStringSetChar) \ 154 V(SeqStringSetChar) \
155 V(ShiftI) \ 155 V(ShiftI) \
156 V(SmiTag) \ 156 V(SmiTag) \
157 V(SmiUntag) \ 157 V(SmiUntag) \
158 V(StackCheck) \ 158 V(StackCheck) \
159 V(StoreCodeEntry) \ 159 V(StoreCodeEntry) \
160 V(StoreContextSlot) \ 160 V(StoreContextSlot) \
161 V(StoreGlobalCell) \ 161 V(StoreGlobalCell) \
162 V(StoreGlobalGeneric) \
163 V(StoreKeyed) \ 162 V(StoreKeyed) \
164 V(StoreKeyedGeneric) \ 163 V(StoreKeyedGeneric) \
165 V(StoreNamedField) \ 164 V(StoreNamedField) \
166 V(StoreNamedGeneric) \ 165 V(StoreNamedGeneric) \
167 V(StringAdd) \ 166 V(StringAdd) \
168 V(StringCharCodeAt) \ 167 V(StringCharCodeAt) \
169 V(StringCharFromCode) \ 168 V(StringCharFromCode) \
170 V(StringCompareAndBranch) \ 169 V(StringCompareAndBranch) \
171 V(SubI) \ 170 V(SubI) \
172 V(TaggedToI) \ 171 V(TaggedToI) \
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1633 } 1632 }
1634 1633
1635 LOperand* value() { return inputs_[0]; } 1634 LOperand* value() { return inputs_[0]; }
1636 LOperand* temp() { return temps_[0]; } 1635 LOperand* temp() { return temps_[0]; }
1637 1636
1638 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell") 1637 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell")
1639 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell) 1638 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell)
1640 }; 1639 };
1641 1640
1642 1641
1643 class LStoreGlobalGeneric V8_FINAL : public LTemplateInstruction<0, 3, 0> {
1644 public:
1645 LStoreGlobalGeneric(LOperand* context,
1646 LOperand* global_object,
1647 LOperand* value) {
1648 inputs_[0] = context;
1649 inputs_[1] = global_object;
1650 inputs_[2] = value;
1651 }
1652
1653 LOperand* context() { return inputs_[0]; }
1654 LOperand* global_object() { return inputs_[1]; }
1655 LOperand* value() { return inputs_[2]; }
1656
1657 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalGeneric, "store-global-generic")
1658 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalGeneric)
1659
1660 Handle<Object> name() const { return hydrogen()->name(); }
1661 StrictModeFlag strict_mode_flag() { return hydrogen()->strict_mode_flag(); }
1662 };
1663
1664
1665 class LLoadContextSlot V8_FINAL : public LTemplateInstruction<1, 1, 0> { 1642 class LLoadContextSlot V8_FINAL : public LTemplateInstruction<1, 1, 0> {
1666 public: 1643 public:
1667 explicit LLoadContextSlot(LOperand* context) { 1644 explicit LLoadContextSlot(LOperand* context) {
1668 inputs_[0] = context; 1645 inputs_[0] = context;
1669 } 1646 }
1670 1647
1671 LOperand* context() { return inputs_[0]; } 1648 LOperand* context() { return inputs_[0]; }
1672 1649
1673 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1650 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1674 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1651 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 1131 matching lines...) Expand 10 before | Expand all | Expand 10 after
2806 2783
2807 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2784 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2808 }; 2785 };
2809 2786
2810 #undef DECLARE_HYDROGEN_ACCESSOR 2787 #undef DECLARE_HYDROGEN_ACCESSOR
2811 #undef DECLARE_CONCRETE_INSTRUCTION 2788 #undef DECLARE_CONCRETE_INSTRUCTION
2812 2789
2813 } } // namespace v8::internal 2790 } } // namespace v8::internal
2814 2791
2815 #endif // V8_MIPS_LITHIUM_MIPS_H_ 2792 #endif // V8_MIPS_LITHIUM_MIPS_H_
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698