Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1944 matching lines...) Expand 10 before | Expand all | Expand 10 after
1955 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1955 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1956 LOperand* value = UseRegister(instr->value()); 1956 LOperand* value = UseRegister(instr->value());
1957 // Use a temp to check the value in the cell in the case where we perform 1957 // Use a temp to check the value in the cell in the case where we perform
1958 // a hole check. 1958 // a hole check.
1959 return instr->RequiresHoleCheck() 1959 return instr->RequiresHoleCheck()
1960 ? AssignEnvironment(new(zone()) LStoreGlobalCell(value, TempRegister())) 1960 ? AssignEnvironment(new(zone()) LStoreGlobalCell(value, TempRegister()))
1961 : new(zone()) LStoreGlobalCell(value, NULL); 1961 : new(zone()) LStoreGlobalCell(value, NULL);
1962 } 1962 }
1963 1963
1964 1964
1965 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1966 LOperand* context = UseFixed(instr->context(), cp);
1967 LOperand* global_object = UseFixed(instr->global_object(), a1);
1968 LOperand* value = UseFixed(instr->value(), a0);
1969 LStoreGlobalGeneric* result =
1970 new(zone()) LStoreGlobalGeneric(context, global_object, value);
1971 return MarkAsCall(result, instr);
1972 }
1973
1974
1975 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 1965 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
1976 LOperand* context = UseRegisterAtStart(instr->value()); 1966 LOperand* context = UseRegisterAtStart(instr->value());
1977 LInstruction* result = 1967 LInstruction* result =
1978 DefineAsRegister(new(zone()) LLoadContextSlot(context)); 1968 DefineAsRegister(new(zone()) LLoadContextSlot(context));
1979 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 1969 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
1980 } 1970 }
1981 1971
1982 1972
1983 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) { 1973 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
1984 LOperand* context; 1974 LOperand* context;
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
2470 2460
2471 2461
2472 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2462 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2473 LOperand* object = UseRegister(instr->object()); 2463 LOperand* object = UseRegister(instr->object());
2474 LOperand* index = UseRegister(instr->index()); 2464 LOperand* index = UseRegister(instr->index());
2475 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2465 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2476 } 2466 }
2477 2467
2478 2468
2479 } } // namespace v8::internal 2469 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698