Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/ia32/lithium-ia32.h

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 V(Return) \ 153 V(Return) \
154 V(SeqStringGetChar) \ 154 V(SeqStringGetChar) \
155 V(SeqStringSetChar) \ 155 V(SeqStringSetChar) \
156 V(ShiftI) \ 156 V(ShiftI) \
157 V(SmiTag) \ 157 V(SmiTag) \
158 V(SmiUntag) \ 158 V(SmiUntag) \
159 V(StackCheck) \ 159 V(StackCheck) \
160 V(StoreCodeEntry) \ 160 V(StoreCodeEntry) \
161 V(StoreContextSlot) \ 161 V(StoreContextSlot) \
162 V(StoreGlobalCell) \ 162 V(StoreGlobalCell) \
163 V(StoreGlobalGeneric) \
164 V(StoreKeyed) \ 163 V(StoreKeyed) \
165 V(StoreKeyedGeneric) \ 164 V(StoreKeyedGeneric) \
166 V(StoreNamedField) \ 165 V(StoreNamedField) \
167 V(StoreNamedGeneric) \ 166 V(StoreNamedGeneric) \
168 V(StringAdd) \ 167 V(StringAdd) \
169 V(StringCharCodeAt) \ 168 V(StringCharCodeAt) \
170 V(StringCharFromCode) \ 169 V(StringCharFromCode) \
171 V(StringCompareAndBranch) \ 170 V(StringCompareAndBranch) \
172 V(SubI) \ 171 V(SubI) \
173 V(TaggedToI) \ 172 V(TaggedToI) \
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 inputs_[0] = value; 1652 inputs_[0] = value;
1654 } 1653 }
1655 1654
1656 LOperand* value() { return inputs_[0]; } 1655 LOperand* value() { return inputs_[0]; }
1657 1656
1658 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell") 1657 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell")
1659 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell) 1658 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell)
1660 }; 1659 };
1661 1660
1662 1661
1663 class LStoreGlobalGeneric V8_FINAL : public LTemplateInstruction<0, 3, 0> {
1664 public:
1665 LStoreGlobalGeneric(LOperand* context,
1666 LOperand* global_object,
1667 LOperand* value) {
1668 inputs_[0] = context;
1669 inputs_[1] = global_object;
1670 inputs_[2] = value;
1671 }
1672
1673 LOperand* context() { return inputs_[0]; }
1674 LOperand* global_object() { return inputs_[1]; }
1675 LOperand* value() { return inputs_[2]; }
1676
1677 DECLARE_CONCRETE_INSTRUCTION(StoreGlobalGeneric, "store-global-generic")
1678 DECLARE_HYDROGEN_ACCESSOR(StoreGlobalGeneric)
1679
1680 Handle<Object> name() const { return hydrogen()->name(); }
1681 StrictModeFlag strict_mode_flag() { return hydrogen()->strict_mode_flag(); }
1682 };
1683
1684
1685 class LLoadContextSlot V8_FINAL : public LTemplateInstruction<1, 1, 0> { 1662 class LLoadContextSlot V8_FINAL : public LTemplateInstruction<1, 1, 0> {
1686 public: 1663 public:
1687 explicit LLoadContextSlot(LOperand* context) { 1664 explicit LLoadContextSlot(LOperand* context) {
1688 inputs_[0] = context; 1665 inputs_[0] = context;
1689 } 1666 }
1690 1667
1691 LOperand* context() { return inputs_[0]; } 1668 LOperand* context() { return inputs_[0]; }
1692 1669
1693 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot") 1670 DECLARE_CONCRETE_INSTRUCTION(LoadContextSlot, "load-context-slot")
1694 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot) 1671 DECLARE_HYDROGEN_ACCESSOR(LoadContextSlot)
(...skipping 1156 matching lines...) Expand 10 before | Expand all | Expand 10 after
2851 2828
2852 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2829 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2853 }; 2830 };
2854 2831
2855 #undef DECLARE_HYDROGEN_ACCESSOR 2832 #undef DECLARE_HYDROGEN_ACCESSOR
2856 #undef DECLARE_CONCRETE_INSTRUCTION 2833 #undef DECLARE_CONCRETE_INSTRUCTION
2857 2834
2858 } } // namespace v8::internal 2835 } } // namespace v8::internal
2859 2836
2860 #endif // V8_IA32_LITHIUM_IA32_H_ 2837 #endif // V8_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698