Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2054 matching lines...) Expand 10 before | Expand all | Expand 10 after
2065 } 2065 }
2066 2066
2067 2067
2068 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 2068 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
2069 LStoreGlobalCell* result = 2069 LStoreGlobalCell* result =
2070 new(zone()) LStoreGlobalCell(UseRegister(instr->value())); 2070 new(zone()) LStoreGlobalCell(UseRegister(instr->value()));
2071 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 2071 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
2072 } 2072 }
2073 2073
2074 2074
2075 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
2076 LOperand* context = UseFixed(instr->context(), esi);
2077 LOperand* global_object = UseFixed(instr->global_object(), edx);
2078 LOperand* value = UseFixed(instr->value(), eax);
2079 LStoreGlobalGeneric* result =
2080 new(zone()) LStoreGlobalGeneric(context, global_object, value);
2081 return MarkAsCall(result, instr);
2082 }
2083
2084
2085 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 2075 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
2086 LOperand* context = UseRegisterAtStart(instr->value()); 2076 LOperand* context = UseRegisterAtStart(instr->value());
2087 LInstruction* result = 2077 LInstruction* result =
2088 DefineAsRegister(new(zone()) LLoadContextSlot(context)); 2078 DefineAsRegister(new(zone()) LLoadContextSlot(context));
2089 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 2079 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
2090 } 2080 }
2091 2081
2092 2082
2093 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) { 2083 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
2094 LOperand* value; 2084 LOperand* value;
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
2657 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2647 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2658 LOperand* object = UseRegister(instr->object()); 2648 LOperand* object = UseRegister(instr->object());
2659 LOperand* index = UseTempRegister(instr->index()); 2649 LOperand* index = UseTempRegister(instr->index());
2660 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2650 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2661 } 2651 }
2662 2652
2663 2653
2664 } } // namespace v8::internal 2654 } } // namespace v8::internal
2665 2655
2666 #endif // V8_TARGET_ARCH_IA32 2656 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698