Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1301 matching lines...) Expand 10 before | Expand all | Expand 10 after
1312 1312
1313 1313
1314 void LoadIC::GenerateMegamorphic(MacroAssembler* masm, ContextualMode mode) { 1314 void LoadIC::GenerateMegamorphic(MacroAssembler* masm, ContextualMode mode) {
1315 // ----------- S t a t e ------------- 1315 // ----------- S t a t e -------------
1316 // -- ecx : name 1316 // -- ecx : name
1317 // -- edx : receiver 1317 // -- edx : receiver
1318 // -- esp[0] : return address 1318 // -- esp[0] : return address
1319 // ----------------------------------- 1319 // -----------------------------------
1320 1320
1321 // Probe the stub cache. 1321 // Probe the stub cache.
1322 ExtraICState extra_ic_state = IC::ComputeExtraICState(mode); 1322 ExtraICState extra_ic_state = LoadIC::ComputeExtraICState(mode);
1323 Code::Flags flags = Code::ComputeFlags( 1323 Code::Flags flags = Code::ComputeFlags(
1324 Code::HANDLER, MONOMORPHIC, extra_ic_state, 1324 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1325 Code::NORMAL, Code::LOAD_IC); 1325 Code::NORMAL, Code::LOAD_IC);
1326 masm->isolate()->stub_cache()->GenerateProbe( 1326 masm->isolate()->stub_cache()->GenerateProbe(
1327 masm, flags, edx, ecx, ebx, eax); 1327 masm, flags, edx, ecx, ebx, eax);
1328 1328
1329 // Cache miss: Jump to runtime. 1329 // Cache miss: Jump to runtime.
1330 GenerateMiss(masm); 1330 GenerateMiss(masm);
1331 } 1331 }
1332 1332
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
1670 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1670 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1671 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1671 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1672 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1672 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1673 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1673 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1674 } 1674 }
1675 1675
1676 1676
1677 } } // namespace v8::internal 1677 } } // namespace v8::internal
1678 1678
1679 #endif // V8_TARGET_ARCH_IA32 1679 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698